From owner-svn-src-head@freebsd.org Sun Jul 9 20:49:57 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D3C3CD94F05 for ; Sun, 9 Jul 2017 20:49:57 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-it0-x231.google.com (mail-it0-x231.google.com [IPv6:2607:f8b0:4001:c0b::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 95B596F76A for ; Sun, 9 Jul 2017 20:49:57 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-it0-x231.google.com with SMTP id 188so7372138itx.0 for ; Sun, 09 Jul 2017 13:49:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=YxuVMm3Kh6FLb5vQZNAdzzja1xUZhCnxRLwcj5MaMCQ=; b=GO/S3WrX2kYfmrs4BktYvaPSAZP59piV8dw3zNKgrUkUvLBVsNdk7P+sfj7IwLv10+ QQ2tJR1PswInzwimH2W1IZ/23QwMu5BejLS3uWzz7OPRsW/ByxvfSgnbH8d2Kz+oepv/ YtvQDHBlVR6HZphHzy5+tcNjNeTB+S4e35ONVVMyAWnbINEFgYOYBUZexKtCm0X7e74q arZ/VlRdoRK6nd0hgskRR05zPzaQ70odDCMYYjZHPwb+/tb31PIADCwa48sFyTB1WaP6 yVBjiaxGnSJEDLmuKUk/cUZgRW77Fb4ipbgp+Me73sM15A/So16IOeElBs4U6rQCozXU CQzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=YxuVMm3Kh6FLb5vQZNAdzzja1xUZhCnxRLwcj5MaMCQ=; b=qCIKnti+tTV89XVujf+VbfAkh/ZY1zlbsaIs91GOJX+CuLrt80VyHpsfF5+7E2LVHN uLBaDlkejJIcKNp87ztRd6oq4tClL8JLBexopi2pk5MyVtACtzChXEH8yfBkxQ0KviLm O4EGZKi6aVFJcWAFCQLaSCDuIT0rM1M2B7mUghcGrRgb8cRfPi0GaOFWMaVqseJVQC0y iQk1FHk8HZgTTfaEdoVVnriKrUxTDkM5sk9tdF7ZOrwUVaNKhmoWAyixDK0+Ya+5Af3d cwxwrggjQynPwviEkddg95JJLqnu4Xlrf5ISZOXFCq0nUk1SMjn19fpFoGVVthSgWyxK bEAw== X-Gm-Message-State: AIVw1130qncENvNPbyN0DJ5gpLunaYYO/bLllFQWVdON5NM0myIbARc0 EOHmBF7edEN0RcrS9orV8buZw5RkaRLW X-Received: by 10.36.25.200 with SMTP id b191mr8978372itb.20.1499633397071; Sun, 09 Jul 2017 13:49:57 -0700 (PDT) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 10.79.212.167 with HTTP; Sun, 9 Jul 2017 13:49:56 -0700 (PDT) X-Originating-IP: [2603:300b:6:5100:5d99:2cb7:7594:1100] In-Reply-To: References: <201707091657.v69GvOar096942@repo.freebsd.org> <20170709184221.GB38352@alchemy.franken.de> From: Warner Losh Date: Sun, 9 Jul 2017 14:49:56 -0600 X-Google-Sender-Auth: -CnpkUN2IjSECpiTCBp31-Pm6O8 Message-ID: Subject: Re: svn commit: r320844 - in head: etc/mtree include lib/libcam sys/amd64/conf sys/arm/broadcom/bcm2835 sys/arm/conf sys/arm/ti sys/cam sys/cam/mmc sys/cam/scsi sys/conf sys/dev/mmc sys/dev/sdhci sys/m... To: Marius Strobl Cc: Warner Losh , src-committers , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 09 Jul 2017 20:49:57 -0000 On Sun, Jul 9, 2017 at 2:40 PM, Warner Losh wrote: > > > On Sun, Jul 9, 2017 at 12:42 PM, Marius Strobl wrote: > >> On Sun, Jul 09, 2017 at 04:57:24PM +0000, Warner Losh wrote: >> > Author: imp >> > Date: Sun Jul 9 16:57:24 2017 >> > New Revision: 320844 >> > URL: https://svnweb.freebsd.org/changeset/base/320844 >> > >> > Log: >> > An MMC/SD/SDIO stack using CAM >> > >> > Implement the MMC/SD/SDIO protocol within a CAM framework. CAM's >> > flexible queueing will make it easier to write non-storage drivers >> > than the legacy stack. SDIO drivers from both the kernel and as >> > userland daemons are possible, though much of that functionality will >> > come later. >> >> At least with a non-MMCCAM kernel, with this revision in place I get >> an endless storm of "unexpected" SDHCI_INT_CARD_INT interrupts during >> boot. Apparently this is due to the fact that sdhci(4) now enables >> these interrupts, but sdhci_generic_intr() neither actually handles >> them nor clears them from intmask. >> > > OK. I'll look into it. Since I don't have an SDHCI card in the system I > tested it in, I never saw these... > Looking at the code, the problem is obvious. It looks like it came in on a late commit to the mmccam integration branch. I'll revert which should solve your problem. Looking at my notes and test systems, I did test this on a NUC, but it was an older version w/o the patch I just reverted. Sorry for the hassle. r320850 > Btw., were mmc.ko and mmcsd.ko disconnected on purpose with this commit? > > > No, I'll reconnect. > This has been done. r320849 Warner