From owner-freebsd-bugs@FreeBSD.ORG  Sun Oct 14 14:50:04 2007
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 3E59C16A46E
	for <freebsd-bugs@hub.freebsd.org>;
	Sun, 14 Oct 2007 14:50:04 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 0F7C113C4A7
	for <freebsd-bugs@hub.freebsd.org>;
	Sun, 14 Oct 2007 14:50:04 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.1/8.14.1) with ESMTP id l9EEo4vk008837
	for <freebsd-bugs@freefall.freebsd.org>; Sun, 14 Oct 2007 14:50:04 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.1/8.14.1/Submit) id l9EEo4eI008836;
	Sun, 14 Oct 2007 14:50:04 GMT (envelope-from gnats)
Date: Sun, 14 Oct 2007 14:50:04 GMT
Message-Id: <200710141450.l9EEo4eI008836@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
From: Eugene Grosbein <eugen@grosbein.pp.ru>
Cc: 
Subject: Re: kern/116608: [panic] [patch] [msdosfs] msdosfs fails to check
	mount options
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Eugene Grosbein <eugen@grosbein.pp.ru>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 14 Oct 2007 14:50:04 -0000

The following reply was made to PR kern/116608; it has been noted by GNATS.

From: Eugene Grosbein <eugen@grosbein.pp.ru>
To: bug-followup@freebsd.org
Cc:  
Subject: Re: kern/116608: [panic] [patch] [msdosfs] msdosfs fails to check mount options
Date: Sun, 14 Oct 2007 22:47:20 +0800

 Hi!
 
 Here is a version of last patch adjusted for 7.0-PRERELEASE:
 
 --- sys/fs/msdosfs/msdosfs_vfsops.c.orig	2007-08-16 01:40:09.000000000 +0800
 +++ sys/fs/msdosfs/msdosfs_vfsops.c	2007-10-14 17:58:20.000000000 +0800
 @@ -265,6 +265,7 @@
  			}
  		}
  		if (!(pmp->pm_flags & MSDOSFSMNT_RONLY) &&
 +		    !vfs_flagopt(mp->mnt_optnew, "noro", NULL, 0) &&
  		    vfs_flagopt(mp->mnt_optnew, "ro", NULL, 0)) {
  			error = VFS_SYNC(mp, MNT_WAIT, td);
  			if (error)
 @@ -314,10 +315,12 @@
  
  			ro_to_rw = 1;
  		}
 +		if(!vfs_flagopt(mp->mnt_optnew, "noro", NULL, 0)) {
  		vfs_flagopt(mp->mnt_optnew, "ro",
  		    &pmp->pm_flags, MSDOSFSMNT_RONLY);
  		vfs_flagopt(mp->mnt_optnew, "ro",
  		    &mp->mnt_flag, MNT_RDONLY);
 +		}
  
  		if (ro_to_rw) {
  			/* Now that the volume is modifiable, mark it dirty. */