From owner-freebsd-hackers@FreeBSD.ORG Mon Jun 10 15:58:45 2013 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 869BC455; Mon, 10 Jun 2013 15:58:43 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1]) by mx1.freebsd.org (Postfix) with ESMTP id A3B081041; Mon, 10 Jun 2013 15:58:43 +0000 (UTC) Received: from jhbbsd.localnet (unknown [209.249.190.124]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id F26DAB9B8; Mon, 10 Jun 2013 11:58:42 -0400 (EDT) From: John Baldwin To: freebsd-hackers@freebsd.org Subject: Re: Fix MNAMELEN or reimplement struct statfs Date: Mon, 10 Jun 2013 11:52:17 -0400 User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110714-p25; KDE/4.5.5; amd64; ; ) References: <51B3B59B.8050903@erdgeist.org> In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201306101152.17966.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Mon, 10 Jun 2013 11:58:43 -0400 (EDT) Cc: mdf@freebsd.org, Dirk Engling X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Jun 2013 15:58:45 -0000 On Saturday, June 08, 2013 9:36:27 pm mdf@freebsd.org wrote: > On Sat, Jun 8, 2013 at 3:52 PM, Dirk Engling wrote: > > > The arbitrary value > > > > #define MNAMELEN 88 /* size of on/from name bufs */ > > > > struct statfs { > > [...] > > char f_mntfromname[MNAMELEN];/* mounted filesystem */ > > char f_mntonname[MNAMELEN]; /* directory on which mounted */ > > }; > > > > currently bites us when trying to use poudriere with errors like > > > > 'mount: tmpfs: File name too long' > > > > > > /poudriere/data/build/91_RELEASE_amd64-REALLY-REALLY-LONG- JAILNAME/ref/wrkdirs > > > > The topic has been discussed several times since 2004 and has been > > postponed each time, the last time when it hit zfs users: > > > > http://lists.freebsd.org/pipermail/freebsd-fs/2010-March/007974.html > > > > So I'd like to point to the calendar, it's 2013 already and there's > > still a static arbitrary (and way too low) limit in one of the core > > areas of the vfs code. > > > > So I'd like to bump the issue and propose either making f_mntfromname a > > dynamic allocation or just increase MNAMELEN, using 10.0 as water shed. > > > > Gleb Kurtsou did this along with the ino64 GSoC project. Unfortunately, > both he and I hit ENOTIME due to the job that pays the bills and it's > never made it back to the main repository. > > IIRC, though, the only reason for doing it with 64-bit ino_t is that he'd > already finished changing the stat/dirent ABI so what was one more. I > think he went with 1024 bytes, which also necessitated not allocating > statfs on the stack for the kernel. He also fixed a few other things since changing this ABI is so invasive IIRC. This really is the right fix for this. Is it in an svn branch that can be updated and a new patch generated? -- John Baldwin