Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 23 Jul 2021 13:33:57 +0200
From:      Emmanuel Vadot <manu@bidouilliste.com>
To:        Alexey Dokuchaev <danfe@freebsd.org>
Cc:        ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org
Subject:   Re: git: 8c256a205fa0 - main - benchmarks/kdiskmark: the port had been updated (+)
Message-ID:  <20210723133357.43902b49f440d5d4b7be8c08@bidouilliste.com>
In-Reply-To: <YPqn16WHJnRK8FUF@FreeBSD.org>
References:  <202107231117.16NBHCB2035487@gitrepo.freebsd.org> <20210723132450.e9013a2ab1ec53d235cd7441@bidouilliste.com> <YPqn16WHJnRK8FUF@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 23 Jul 2021 11:28:23 +0000
Alexey Dokuchaev <danfe@freebsd.org> wrote:

> On Fri, Jul 23, 2021 at 01:24:50PM +0200, Emmanuel Vadot wrote:
> > On Fri, 23 Jul 2021 11:17:12 GMT
> > Alexey Dokuchaev <danfe@FreeBSD.org> wrote:
> > 
> > > commit 8c256a205fa0cf4805f51040a1a6d10af3b48ca9
> 
> Please don't ovebquote.
> 
> > > 
> > >     benchmarks/kdiskmark: the port had been updated (+)
> > >     
> > >     - Update KDiskMark to version 2.2.1
> > 
> >  Is it that hard for you to put in the first line
> > "benchmarks/kdiskmark: update to version 2.2.1" ???
> 
> I do that if that's the only change in the commit.  This time it
> was not, there were other changes documented in the commit log,

benchmarks/kdiskmark: update to version 2.2.1
While here : 
  - Make cache clearing and KDE dependency optional
  - Amend port description and add pkg-help file

There, I've fixed it for you.

> so the first line should be ignored (it is marked with plus sign
> for that reason).

 The first line is the mail subject message and what shown in git log
--onleline so it needs to contain proper info and not something that
should be ignored.

> ./danfe




-- 
Emmanuel Vadot <manu@bidouilliste.com> <manu@FreeBSD.org>



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20210723133357.43902b49f440d5d4b7be8c08>