From owner-svn-ports-head@freebsd.org  Fri Apr 15 17:00:02 2016
Return-Path: <owner-svn-ports-head@freebsd.org>
Delivered-To: svn-ports-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 70B3EAED4F4;
 Fri, 15 Apr 2016 17:00:02 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2001:1900:2254:206c::16:87])
 by mx1.freebsd.org (Postfix) with ESMTP id 6761F16AF;
 Fri, 15 Apr 2016 17:00:02 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1033)
 id 667201D24; Fri, 15 Apr 2016 17:00:02 +0000 (UTC)
Date: Fri, 15 Apr 2016 17:00:02 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Kurt Jaeger <pi@FreeBSD.org>
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Subject: Re: svn commit: r413352 - in head/www/rt44: . files
Message-ID: <20160415170002.GA60195@FreeBSD.org>
References: <201604151628.u3FGSuAC096464@repo.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201604151628.u3FGSuAC096464@repo.freebsd.org>
User-Agent: Mutt/1.6.0 (2016-04-01)
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-head>, 
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 15 Apr 2016 17:00:02 -0000

On Fri, Apr 15, 2016 at 04:28:56PM +0000, Kurt Jaeger wrote:
> New Revision: 413352
> URL: https://svnweb.freebsd.org/changeset/ports/413352
> 
> Log:
>   www/rt44: re-surrect as repo-copy of rt42
>   
>   PR:		208229
>   Submitted by:	mat

PR 208229 was not submitted by mat@, please stop adding bogus attribution
to commit logs.

>  COMMENT=	RT is an industrial-grade ticketing system written in Perl

Violation of Section 5.6 of the PHB (clause #2).

> @@ -90,7 +91,7 @@ SQLITE_RUN_DEPENDS=		${SQLITE_DEPS}
>  
>  DEVELOPER_DESC=			Configure for Developers
>  DEVELOPER_RUN_DEPENDS=		${DEVELOPER_DEPS}

Wrong spelling, "developers" is not a proper noun and should not be
capitalized.

>  SMIME_DESC=			Enable Secure MIME support

Also wrong, correct version of SMIME_DESC is "Secure MIME support".

> ---- ./Makefile.in.orig	2014-05-06 17:59:04.000000000 +0100
> -+++ ./Makefile.in	2014-05-14 15:26:37.708277377 +0100
> +--- ./Makefile.in.orig	2014-05-06 17:59:04 UTC
> ++++ ./Makefile.in

That's weird: looks like patches were (re)generated by `make makepatch`,
but still contain bogus leading `./' in the filenames.

./danfe