From owner-freebsd-net@freebsd.org Wed Mar 22 17:50:52 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8A552D18E13 for ; Wed, 22 Mar 2017 17:50:52 +0000 (UTC) (envelope-from ozkan.kirik@gmail.com) Received: from mail-qk0-x234.google.com (mail-qk0-x234.google.com [IPv6:2607:f8b0:400d:c09::234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 433091901; Wed, 22 Mar 2017 17:50:52 +0000 (UTC) (envelope-from ozkan.kirik@gmail.com) Received: by mail-qk0-x234.google.com with SMTP id p64so162405298qke.1; Wed, 22 Mar 2017 10:50:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=AJ0AN35Q2lTrQPpEANb/vaV6fNisAR5jElxiZxb0ACQ=; b=hDA06R9q+V2Mw1Q9wzmMcgwMJdPjwU5gFUpKIIrIa86L/U7fach8WtysEMcb84PA/r tsv6aKQCmXAZVZox5tsEHwBDKhTj2OVNpEzZyxbRoQpPQPos9F4W5Vwfq4H1iSovrc5x OrodRIqoVyzqgXgoftQsCB0IijSN+dpwqHiGqPGqr3o9rGZvOsy3vUvRMT9XKaiQeiSs r1lxXKGPk62LTrKzCapOYdlRq2KbdTvnESaD7WvUzekxSkvJKiZBYqpsZVLJ/wlXk50o vLRnnB+lUeLK32W8m/imqloG3XTYojv8xCBtyRbaefh6mKMGM8THolzb7N6diXQ4sLu9 kwqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=AJ0AN35Q2lTrQPpEANb/vaV6fNisAR5jElxiZxb0ACQ=; b=ihZQZx3TFYlKnWfi7N45oNEqRsH/AqmHIsbis79+VtbWgNf07LeQu3GTD5Vmat9yad AQMaog6zd7EHNu/T/KMJGGUDxx5U7yNWgMGdvDrpH1UN3Eq8e3uBScv5pxds78L9Gwh1 JTbDPy9cRhgn5bLic54wej424q8skCFaSyEuGZhIFBQpR5Pe7UCZUOeo+tNLtDtIELrg isHLteEf2/UvYHnFeObIYKDYPGnhejmZ1q6bxRdf7JL6qfrn+E3JztyrGNYNUnklLUok qrQ3pSO/p5crKKUolokB/1nCfh/yq5fKCoj8OTnLb6D/HNu6tD8gBMo3CONiJ6b+3Jux A5wg== X-Gm-Message-State: AFeK/H3naIFCz4DMoVZn4DTAoMMMC/Ft/NXxH9vhPorB6O9jznLXaAHEqvrZtWZyM7YR95sv7zBGd/3G6+eBAQ== X-Received: by 10.55.131.68 with SMTP id f65mr36620875qkd.1.1490205050879; Wed, 22 Mar 2017 10:50:50 -0700 (PDT) MIME-Version: 1.0 Received: by 10.12.179.135 with HTTP; Wed, 22 Mar 2017 10:50:50 -0700 (PDT) In-Reply-To: References: From: =?UTF-8?B?w5Z6a2FuIEtJUklL?= Date: Wed, 22 Mar 2017 20:50:50 +0300 Message-ID: Subject: Re: if_epair altq support problem To: =?UTF-8?Q?Ermal_Lu=C3=A7i?= Cc: "freebsd-net@freebsd.org" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Mar 2017 17:50:52 -0000 Sorry, I mistested on 10.3RELENG. it works on 11 RELENG, But at 10.3RELENG it throws /usr/src/sys/modules/if_epair/../../net/if_epair.c:830:2: error: implicit declaration of function 'if_setstartfn' is invalid in C99 [-Werror,-Wimplicit-function-declaration] On Wed, Mar 22, 2017 at 8:18 PM, =C3=96zkan KIRIK w= rote: > Thank You Ermal ! > > It works perfectly, can you commit this patch to 11.0 RELENG and MFC to > 10.3 RELENG ? > > Regards > > On Wed, Mar 22, 2017 at 6:59 AM, Ermal Lu=C3=A7i wrote: > >> >> >> On Tue, Mar 21, 2017 at 5:26 AM, =C3=96zkan KIRIK >> wrote: >> >>> Hello, >>> >>> I sent this email also to freebsd-pf list. But I think that the main >>> problem is belongs to sys/net/if_epair.c. >>> >>> I'm using FreeBSD 10.3-p17 amd64. epair pseudo device is listed as >>> supperted deviced at the Man page of altq(4). >>> From man page of altq : >>> >>> *SUPPORTED DEVICES * >>> >>> The driver modifications described in altq(9) >>> >> ropos=3D0&manpath=3DFreeBSD+11.0-RELEASE+and+Ports> >>> are required to use a cer- >>> tain network card with *ALTQ*. They have been applied to th= e >>> following >>> hardware drivers: ae(4) >>> >> pos=3D0&manpath=3DFreeBSD+11.0-RELEASE+and+Ports>, >>> age(4) >> opos=3D0&manpath=3DFreeBSD+11.0-RELEASE+and+Ports>, >>> alc(4) >> opos=3D0&manpath=3DFreeBSD+11.0-RELEASE+and+Ports>, >>> ale(4) >> opos=3D0&manpath=3DFreeBSD+11.0-RELEASE+and+Ports>, >>> an(4) >> pos=3D0&manpath=3DFreeBSD+11.0-RELEASE+and+Ports>, >>> ath(4) >> opos=3D0&manpath=3DFreeBSD+11.0-RELEASE+and+Ports>, >>> aue(4) >> opos=3D0&manpath=3DFreeBSD+11.0-RELEASE+and+Ports>, >>> axe(4) >> opos=3D0&manpath=3DFreeBSD+11.0-RELEASE+and+Ports>, >>> bce(4) >> opos=3D0&manpath=3DFreeBSD+11.0-RELEASE+and+Ports>, >>> bfe(4) >> opos=3D0&manpath=3DFreeBSD+11.0-RELEASE+and+Ports>, >>> bge(4) >> opos=3D0&manpath=3DFreeBSD+11.0-RELEASE+and+Ports>, >>> bxe(4) >> opos=3D0&manpath=3DFreeBSD+11.0-RELEASE+and+Ports>, >>> cas(4) >> opos=3D0&manpath=3DFreeBSD+11.0-RELEASE+and+Ports>, >>> cxgbe(4) >> propos=3D0&manpath=3DFreeBSD+11.0-RELEASE+and+Ports>, >>> dc(4) >> pos=3D0&manpath=3DFreeBSD+11.0-RELEASE+and+Ports>, >>> de(4) >> pos=3D0&manpath=3DFreeBSD+11.0-RELEASE+and+Ports>, >>> ed(4) >> pos=3D0&manpath=3DFreeBSD+11.0-RELEASE+and+Ports>, >>> em(4) >> pos=3D0&manpath=3DFreeBSD+11.0-RELEASE+and+Ports>, >>> ep(4) >> pos=3D0&manpath=3DFreeBSD+11.0-RELEASE+and+Ports>, >>> epair(4) >> propos=3D0&manpath=3DFreeBSD+11.0-RELEASE+and+Ports>, >>> >>> .... >>> >>> But while trying to use it the system says that it's not suppoerted. I >>> tried on FreeBSD 11 also. The output is below: >>> >>> pf.conf : >>> altq on epair0b hfsc bandwidth 1Mb queue { ftp, ssh, icmp, other } >>> queue ftp bandwidth 30% priority 0 hfsc (upperlimit 99%) >>> queue ssh bandwidth 30% priority 2 hfsc (upperlimit 99%) >>> queue icmp bandwidth 10% priority 2 hfsc (upperlimit 99%) >>> queue other bandwidth 30% priority 1 hfsc (default upperlimit 99%) >>> >>> >>> # ifconfig epair0 create >>> # ifconfig epair0a up >>> # ifconfig epair0b up >>> # pfctl -f pf.conf >>> pfctl: epair0b: driver does not support altq >>> >>> # sysctl -a | grep ALTQ >>> options ALTQ_NOPCC >>> options ALTQ_PRIQ >>> options ALTQ_CDNR >>> options ALTQ_HFSC >>> options ALTQ_RIO >>> options ALTQ_RED >>> options ALTQ_CBQ >>> options ALTQ >>> >>> >>> I have a look on /usr/src/sys/net/if_epair.c, and found the ALTQ sectio= n: >>> >>> 514 #ifdef ALTQ >>> 515 /* Support ALTQ via the clasic if_start() path. */ >>> 516 IF_LOCK(&ifp->if_snd); >>> 517 if (ALTQ_IS_ENABLED(&ifp->if_snd)) { >>> 518 ALTQ_ENQUEUE(&ifp->if_snd, m, NULL, error); >>> 519 if (error) >>> 520 ifp->if_snd.ifq_drops++; >>> 521 IF_UNLOCK(&ifp->if_snd); >>> 522 if (!error) { >>> 523 ifp->if_obytes +=3D len; >>> 524 if (mflags & (M_BCAST|M_MCAST)) >>> 525 ifp->if_omcasts++; >>> 526 >>> 527 if ((ifp->if_drv_flags & IFF_DRV_OACTIVE) >>> =3D=3D 0) >>> 528 epair_start_locked(ifp); >>> 529 else >>> 530 (void)epair_add_ifp_for_drain >>> ing(ifp); >>> 531 } >>> 532 return (error); >>> 533 } >>> 534 IF_UNLOCK(&ifp->if_snd); >>> 535 #endif >>> >>> >> >> Just apply manually this patch to make it work. >> >> diff --git a/sys/net/if_epair.c b/sys/net/if_epair.c >> index 540f06c..04733a5 100644 >> --- a/sys/net/if_epair.c >> +++ b/sys/net/if_epair.c >> @@ -827,9 +827,11 @@ epair_clone_create(struct if_clone *ifc, char *name= , >> size_t len, caddr_t params) >> ifp->if_capabilities =3D IFCAP_VLAN_MTU; >> ifp->if_capenable =3D IFCAP_VLAN_MTU; >> ifp->if_start =3D epair_start; >> + if_setstartfn(ifp, epair_start); >> + if_setsendqlen(ifp, ifqmaxlen); >> + if_setsendqready(ifp); >> ifp->if_ioctl =3D epair_ioctl; >> ifp->if_init =3D epair_init; >> - ifp->if_snd.ifq_maxlen =3D ifqmaxlen; >> /* Assign a hopefully unique, locally administered etheraddr. */ >> eaddr[0] =3D 0x02; >> eaddr[3] =3D (ifp->if_index >> 8) & 0xff; >> @@ -852,10 +854,11 @@ epair_clone_create(struct if_clone *ifc, char >> *name, size_t len, caddr_t params) >> ifp->if_flags =3D IFF_BROADCAST | IFF_SIMPLEX | IFF_MULTICAST; >> ifp->if_capabilities =3D IFCAP_VLAN_MTU; >> ifp->if_capenable =3D IFCAP_VLAN_MTU; >> - ifp->if_start =3D epair_start; >> + if_setstartfn(ifp, epair_start); >> + if_setsendqlen(ifp, ifqmaxlen); >> + if_setsendqready(ifp); >> ifp->if_ioctl =3D epair_ioctl; >> ifp->if_init =3D epair_init; >> - ifp->if_snd.ifq_maxlen =3D ifqmaxlen; >> /* We need to play some tricks here for the second interface. */ >> strlcpy(name, epairname, len); >> error =3D if_clone_create(name, len, (caddr_t)scb); >> >> >> >> >> >>> I have no idea that why it says that it doesn't support altq altough th= e >>> source code contains ALTQ section. >>> >>> >>> Regards >>> =C3=96zkan KIRIK >>> _______________________________________________ >>> freebsd-net@freebsd.org mailing list >>> https://lists.freebsd.org/mailman/listinfo/freebsd-net >>> To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org" >> >> >> >> >> -- >> Ermal >> > >