Date: Mon, 16 Feb 2015 01:34:09 +0000 From: "Bjoern A. Zeeb" <bz@FreeBSD.org> To: Gleb Smirnoff <glebius@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r278828 - head/sys/netinet6 Message-ID: <8750BD23-1384-4065-8368-C332F6683814@FreeBSD.org> In-Reply-To: <20150216013000.GB15484@FreeBSD.org> References: <201502160112.t1G1CKd0074570@svn.freebsd.org> <C993C12A-0F69-4BBF-86E8-D361B3F3A764@FreeBSD.org> <20150216013000.GB15484@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> On 16 Feb 2015, at 01:30 , Gleb Smirnoff <glebius@FreeBSD.org> wrote: >=20 > On Mon, Feb 16, 2015 at 01:25:05AM +0000, Bjoern A. Zeeb wrote: > B>=20 > B> > On 16 Feb 2015, at 01:12 , Gleb Smirnoff <glebius@freebsd.org> = wrote: > B> >=20 > B> > Author: glebius > B> > Date: Mon Feb 16 01:12:20 2015 > B> > New Revision: 278828 > B> > URL: https://svnweb.freebsd.org/changeset/base/278828 > B> >=20 > B> > Log: > B> > Factor out ip6_deletefraghdr() function, to be shared between = IPv6 > B> > stack and pf(4). > B> >=20 > B> > Submitted by: Kristof Provost > B> > Reviewed by: ae > B> > Differential Revision: D1764 > B> >=20 > B> > Modified: > B> > head/sys/netinet6/frag6.c > B> > head/sys/netinet6/ip6_output.c > B>=20 > B> Why did it have to move file? But the new function is in ip6_output and the consumer stays in frag6 = and will be in pf? So the new function moved to a different file = without consumer rather than just on top of the old function? Keep = code logically together seems to make more sense to me. What am I = missing?=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?8750BD23-1384-4065-8368-C332F6683814>