From owner-freebsd-current@FreeBSD.ORG Tue Jun 10 19:25:12 2008 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id AA5311065751 for ; Tue, 10 Jun 2008 19:25:12 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (bigknife-pt.tunnel.tserv9.chi1.ipv6.he.net [IPv6:2001:470:1f10:75::2]) by mx1.freebsd.org (Postfix) with ESMTP id 29F928FC12 for ; Tue, 10 Jun 2008 19:25:12 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from localhost.corp.yahoo.com (john@localhost [IPv6:::1]) (authenticated bits=0) by server.baldwin.cx (8.14.2/8.14.2) with ESMTP id m5AJOqYx064458; Tue, 10 Jun 2008 15:25:05 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: Florian Smeets Date: Tue, 10 Jun 2008 14:02:01 -0400 User-Agent: KMail/1.9.7 References: <200805302339.33935.jhb@freebsd.org> <200806041100.20911.jhb@freebsd.org> <484E627C.6090909@kasimir.com> In-Reply-To: <484E627C.6090909@kasimir.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200806101402.01555.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [IPv6:::1]); Tue, 10 Jun 2008 15:25:05 -0400 (EDT) X-Virus-Scanned: ClamAV 0.91.2/7425/Tue Jun 10 13:42:21 2008 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-2.5 required=4.2 tests=AWL,BAYES_00,NO_RELAYS autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: current@freebsd.org Subject: Re: tx(4) MPSAFE patch X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Jun 2008 19:25:12 -0000 On Tuesday 10 June 2008 07:16:12 am Florian Smeets wrote: > John Baldwin wrote: > > On Tuesday 03 June 2008 05:34:47 pm Florian Smeets wrote: > >> John Baldwin wrote: > >>> On Monday 02 June 2008 07:10:11 pm Florian Smeets wrote: > >>>> Florian Smeets wrote: > >>>>> John Baldwin wrote: > >>>>>> On Monday 02 June 2008 05:09:57 pm Florian Smeets wrote: > >>>>>>> John Baldwin wrote: > >>>>>>>> I have a patch to make tx(4) MPSAFE. I do not have the hardware to > >>>>>>>> test > >>>>>> this > >>>>>>>> however. Unlike many of the previous patches, though, this driver > >>>>>>>> appears > >>>>>> to > >>>>>>>> be for hardware that is not entirely ancient, so there is hopefully a > >>>>>> decent > >>>>>>>> chance someone can test this. > >>>>>>>> > >>>>>>>> http://www.FreeBSD.org/~jhb/patches/tx.patch > >>>>>>>> > >>> Ok, I've updated the patch again (same URL) which should fix the witness > >>> warnings. I also botched the watchdog timer in the previous patch and > > that > >>> should be fixed now, too. > >>> > >> Hi John, > >> > >> still no go. Another mutex not owned panic. I'll be away until Tuesday, > >> I'll be happy to test further patches than. > > > > Ok, I've updated the patch again as that assertion isn't needed (there isn't a > > need for locking during prior to ether_ifattach() and bus_setup_intr()). > > > > Hi John, > > it works as expected now > > tx0: port 0xc400-0xc4ff mem > 0xe7000000-0xe7000fff irq 18 at device 11.0 on pci0 > miibus0: on tx0 > acphy0: PHY 3 on miibus0 > acphy0: 10baseT, 10baseT-FDX, 100baseTX, 100baseTX-FDX, auto > type SMC9432TX_2 > tx0: Ethernet address: 00:e0:29:6c:2e:47 > tx0: [ITHREAD] > > I tried to push some traffic through the interface and no strange > symptoms yet. So i guess the patch is O.K. now. Cool, thanks for testing! -- John Baldwin