From owner-freebsd-testing@FreeBSD.ORG Thu Mar 6 18:20:56 2014 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 7BB40C85; Thu, 6 Mar 2014 18:20:56 +0000 (UTC) Received: from mail-vc0-x230.google.com (mail-vc0-x230.google.com [IPv6:2607:f8b0:400c:c03::230]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 23BF68E5; Thu, 6 Mar 2014 18:20:56 +0000 (UTC) Received: by mail-vc0-f176.google.com with SMTP id lc6so2478493vcb.7 for ; Thu, 06 Mar 2014 10:20:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=iKHMLGLAXq7i4/LVvStKaN4dZo0nJYGgg/KXXrNKeHM=; b=eaglvkZNT4Bj5OdATdaXhZrigJp04cprmbZ7eX/LKrLJsQkWNJgy9fpwFBFZkMRybt X61sRrmoCnPJb128rbOtrUTiwWspZYIHNSWFs4B4/nR015iBssk9MoRgN5wFnOJSVV9V 2cLq2rgl7z08LcMSPPCopC0jm2bL0Y5m+L95lyyJdGZAKgtDKiqBa/caRJVhQYlbVHKW ZA6vVl/923aRzEiEzf9wQptCAVaJJ0LyMV3KiDkBn9WRNNtJz7HT3LyAJG5aoqIEO7Rh pew3rwr9218kuvnFH8QBMboi12T6y29Stzq/GdPio6jyAoKoulTz3qfvNjqmle5MR47L Lrrw== MIME-Version: 1.0 X-Received: by 10.58.128.72 with SMTP id nm8mr6451058veb.18.1394130055257; Thu, 06 Mar 2014 10:20:55 -0800 (PST) Received: by 10.221.67.136 with HTTP; Thu, 6 Mar 2014 10:20:55 -0800 (PST) In-Reply-To: References: <20140305085806.GA70478@x2.osted.lan> <20140306112322.GA10664@x2.osted.lan> <20140306153247.GA22830@x2.osted.lan> <6A23D2B5-4EAA-46EF-A582-8C55FE0ED46B@gmail.com> <20140306162934.GB25614@x2.osted.lan> Date: Thu, 6 Mar 2014 10:20:55 -0800 Message-ID: Subject: Re: Test scenario for sysctl kern.maxfiles From: Garrett Cooper To: Julio Merino Content-Type: text/plain; charset=ISO-8859-1 Cc: Garrett Cooper , Peter Holm , "freebsd-testing@freebsd.org" X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Mar 2014 18:20:56 -0000 On Thu, Mar 6, 2014 at 9:41 AM, Julio Merino wrote: > On Thu, Mar 6, 2014 at 11:29 AM, Peter Holm wrote: >> On Thu, Mar 06, 2014 at 07:44:58AM -0800, Garrett Cooper wrote: >>> >>> ATF forks, doesn?t spawns threads: >>> >>> # grep -r pthread contrib/atf/ || echo not threaded >>> not threaded >>> >> >> Hmm ... OK. >> >> $ ldd /usr/tests/sys/kern/unix_seqpacket_test >> /usr/tests/sys/kern/unix_seqpacket_test: >> libthr.so.3 => /lib/libthr.so.3 (0x2806f000) >> libatf-c.so.1 => /usr/lib/libatf-c.so.1 (0x28091000) >> libc.so.7 => /lib/libc.so.7 (0x280a5000) >> $ > > That's a property of this test program, not of atf: > > $ grep -i thread tests/sys/kern/Makefile > LDADD+= -lpthread That should be LDADD.unix_seqpacket_test+= -lpthread I'd be sure to test this before committing though. It *should* work, but bsd.progs.mk [in its current incarnation] breaks POLA with some variables compared to bsd.prog.mk in NetBSD. Cheers, -Garrett