From owner-cvs-src@FreeBSD.ORG Sun Feb 27 02:01:27 2005 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 115D316A4CE; Sun, 27 Feb 2005 02:01:27 +0000 (GMT) Received: from ylpvm01.prodigy.net (ylpvm01-ext.prodigy.net [207.115.57.32]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9F80643D39; Sun, 27 Feb 2005 02:01:26 +0000 (GMT) (envelope-from nate@root.org) Received: from [10.0.0.115] (adsl-64-171-186-189.dsl.snfc21.pacbell.net [64.171.186.189])j1R21PvE013247; Sat, 26 Feb 2005 21:01:25 -0500 Message-ID: <422129F4.5050600@root.org> Date: Sat, 26 Feb 2005 18:01:24 -0800 From: Nate Lawson User-Agent: Mozilla Thunderbird 1.0RC1 (X11/20041205) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Marcel Moolenaar References: <20050227002323.AEFC716A55A@hub.freebsd.org> <42211F1D.30801@root.org> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.sbin/powerd powerd.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 27 Feb 2005 02:01:27 -0000 Marcel Moolenaar wrote: > > On Feb 26, 2005, at 5:15 PM, Nate Lawson wrote: > >> Marcel Moolenaar wrote: >> >>> marcel 2005-02-27 00:23:19 UTC >>> FreeBSD src repository >>> Modified files: >>> usr.sbin/powerd powerd.c Log: >>> Unbreak !i386 platforms. Only i386 has APM, so don't try to fallback >>> on APM on other platforms. >>> Revision Changes Path >>> 1.3 +11 -1 src/usr.sbin/powerd/powerd.c >> >> >> Thanks. It would be cleaner to move this code into apm_init_ac() and >> acpm_get_ac() functions so the ifdef could be in just one place. > > > Agreed. That would also make it easier to have powerd(8) on platforms > that have neither APM nor ACPI, but have something else (possibly). Done. Shouldn't have drunk all that tea (yunnan gold, quite good.) >> I think there is also one other issue. It would be cleaner to check >> for the acpi sysctl in the rc.d script and return immediately rather >> than starting powerd and it bombing out once it discovers this. > > > I'm not sure. I think PowerPC will benefit if powerd(8) grows support > for wharever is present there. In that light, it makes sense to treat > powerd(8) as a generic service and thus have it started unconditionally. > > Just a thought, Yep. At least ARM has several cpufreq drivers to learn from in Linux. I also reread the code and saw that in the case of all AC stuff failing, we just use the normal policy (-n). So this should work as-is on other platforms. -- Nate