Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 29 Nov 2013 11:45:08 +0100
From:      Rusmir Dusko <nemysis@FreeBSD.org>
To:        Matthias Andree <mandree@FreeBSD.org>, Alexey Dokuchaev <danfe@FreeBSD.org>
Cc:        svn-ports-head@freebsd.org, nemysis@FreeBSD.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org
Subject:   Re: svn commit: r335127 - head/graphics/OpenEXR
Message-ID:  <20131129104508.GA13570@misterbean90now>

next in thread | raw e-mail | index | archive | help
> Rusmir,
> 
> we would normally also include a few words that explain:
> 
> - why the upstream has re-rolled a tarball
> 
> - how you have made sure that the tarball has not been 'enhanced' with a
> Trojan horse.
> 
> It is also a good idea to tell the upstream _not_ to ever re-roll
> tarballs.  If they change the contents, they should change the name.


> I think you forgot to summarize the changes. :)

Thanks for the Report and sorry that i have not give in commit message

- Remove obsolete REINPLACE_CMD
  Upstream have changed Makefile.am and Makefile.in

Changes are only this in Sources

diff -ruN openexr-2.1.0-before openexr-2.1.0
colordiff 1.0.13 (http://www.colordiff.org/)
(C)2002-2012 Dave Ewart, davee@sungate.co.uk

diff -ruN openexr-2.1.0-before/IlmImf/Makefile.am openexr-2.1.0/IlmImf/Makefile.am
--- openexr-2.1.0-before/IlmImf/Makefile.am     2013-11-12 00:09:51.000000000 +0100
+++ openexr-2.1.0/IlmImf/Makefile.am    2013-11-27 20:18:55.000000000 +0100
@@ -154,7 +154,8 @@
                           ImfNamespace.h ImfForward.h ImfExport.h \
                           ImfMisc.h          \
                           ImfPartHelper.h \
-                          ImfDeepImageState.h
+                          ImfDeepImageState.h \
+                          ImfDeepImageStateAttribute.h
 
 noinst_HEADERS = ImfCompressor.h    \
                 ImfRleCompressor.h \
diff -ruN openexr-2.1.0-before/IlmImf/Makefile.in openexr-2.1.0/IlmImf/Makefile.in
--- openexr-2.1.0-before/IlmImf/Makefile.in     2013-11-13 01:33:11.000000000 +0100
+++ openexr-2.1.0/IlmImf/Makefile.in    2013-11-27 20:21:26.000000000 +0100
@@ -424,7 +424,8 @@
                           ImfNamespace.h ImfForward.h ImfExport.h \
                           ImfMisc.h          \
                           ImfPartHelper.h \
-                          ImfDeepImageState.h
+                          ImfDeepImageState.h \
+                          ImfDeepImageStateAttribute.h



And i commit with these Changes in Port Makefile

/usr/local/ports/local/In-Review/graphics/OpenEXR/ > svn diff
Index: Makefile
===================================================================
--- Makefile    (revision 335150)
+++ Makefile    (working copy)
@@ -64,9 +64,6 @@
        @(cd ${WRKSRC}; ${SETENV} ${MAKE_ENV} ${MAKE} ${MAKE_FLAGS} ${MAKEFILE} ${MAKE_ARGS} check)
 
 post-install:
-       ${INSTALL_DATA} ${WRKSRC}/IlmImf/ImfDeepImageStateAttribute.h \
-               ${STAGEDIR}${PREFIX}/include/${PORTNAME}/
-
        @${MKDIR} ${STAGEDIR}${DOCSDIR}
        ${INSTALL_DATA} ${DOC_FILES1:S|^|${DOCSRCDIR1}/|} ${STAGEDIR}${DOCSDIR}
        @${MKDIR} ${STAGEDIR}${DOCSDIR2}

-- 
Best regards,
Rusmir Dusko



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20131129104508.GA13570>