From owner-svn-src-user@FreeBSD.ORG  Tue Aug 10 18:58:06 2010
Return-Path: <owner-svn-src-user@FreeBSD.ORG>
Delivered-To: svn-src-user@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 8153D106564A;
	Tue, 10 Aug 2010 18:58:06 +0000 (UTC) (envelope-from des@FreeBSD.org)
Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c])
	by mx1.freebsd.org (Postfix) with ESMTP id 717B78FC1E;
	Tue, 10 Aug 2010 18:58:06 +0000 (UTC)
Received: from svn.freebsd.org (localhost [127.0.0.1])
	by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id o7AIw6Y4006104;
	Tue, 10 Aug 2010 18:58:06 GMT (envelope-from des@svn.freebsd.org)
Received: (from des@localhost)
	by svn.freebsd.org (8.14.3/8.14.3/Submit) id o7AIw6Bh006102;
	Tue, 10 Aug 2010 18:58:06 GMT (envelope-from des@svn.freebsd.org)
Message-Id: <201008101858.o7AIw6Bh006102@svn.freebsd.org>
From: Dag-Erling Smorgrav <des@FreeBSD.org>
Date: Tue, 10 Aug 2010 18:58:06 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-user@freebsd.org
X-SVN-Group: user
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Cc: 
Subject: svn commit: r211152 - user/des/phybs
X-BeenThere: svn-src-user@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the experimental &quot; user&quot;
	src tree" <svn-src-user.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-user>,
	<mailto:svn-src-user-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-user>
List-Post: <mailto:svn-src-user@freebsd.org>
List-Help: <mailto:svn-src-user-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-user>,
	<mailto:svn-src-user-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 10 Aug 2010 18:58:06 -0000

Author: des
Date: Tue Aug 10 18:58:06 2010
New Revision: 211152
URL: http://svn.freebsd.org/changeset/base/211152

Log:
  Increase MINSIZE; there isn't much point in doing 512-byte
  transactions, as they will always be either perfectly aligned or
  short.
  
  Increase STEP to MAXSIZE * 4; having STEP equal to MAXSIZE means that
  the last round actually tests sequential reading / writing, which is
  not what we're after.
  
  Instead of testing all offsets from 0 to size, test 0 and power-of-two
  multiples of BSIZE, since we assume that the physical block size is a
  power-of-two multiple of BSIZE.
  
  This should both shorten the test's run time and improve the
  significance of its output.

Modified:
  user/des/phybs/phybs.c

Modified: user/des/phybs/phybs.c
==============================================================================
--- user/des/phybs/phybs.c	Tue Aug 10 18:29:39 2010	(r211151)
+++ user/des/phybs/phybs.c	Tue Aug 10 18:58:06 2010	(r211152)
@@ -36,9 +36,10 @@
 #include <string.h>
 #include <unistd.h>
 
-#define MINSIZE		512
+#define BSIZE		512
+#define MINSIZE		1024
 #define MAXSIZE		8192
-#define STEP		MAXSIZE
+#define STEP		(MAXSIZE * 4)
 #define COUNT		65536
 
 static int opt_r = 0;
@@ -137,9 +138,12 @@ main(int argc, char *argv[])
 	printf("%8s%8s%8s%8s%12s%8s%8s\n",
 	    "count", "size", "offset", "step",
 	    "msec", "tps", "kBps");
-	for (size_t size = MINSIZE; size <= MAXSIZE; size *= 2)
-		for (off_t offset = 0; offset < (off_t)size; offset += 512)
+	for (size_t size = MINSIZE; size <= MAXSIZE; size *= 2) {
+		printf("\n");
+		scan(fd, size, 0, STEP, COUNT);
+		for (off_t offset = BSIZE; offset <= (off_t)size; offset *= 2)
 			scan(fd, size, offset, STEP, COUNT);
+	}
 	close(fd);
 	exit(0);
 }