From owner-freebsd-current@FreeBSD.ORG Mon Aug 22 21:39:56 2011 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1EF13106564A; Mon, 22 Aug 2011 21:39:56 +0000 (UTC) (envelope-from yanegomi@gmail.com) Received: from mail-qy0-f182.google.com (mail-qy0-f182.google.com [209.85.216.182]) by mx1.freebsd.org (Postfix) with ESMTP id 9CB918FC14; Mon, 22 Aug 2011 21:39:55 +0000 (UTC) Received: by qyk9 with SMTP id 9so2964223qyk.13 for ; Mon, 22 Aug 2011 14:39:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=NLtuO9F7ILEFMe/iyoZ//gJ4K6L25dVxjGp+SrcoRXM=; b=Ov3Jdbh6AJDX0P0WlKgtrTTX5fFgGbOLsNyHVCrkKaTWCcO0A2vfq+Dnl2BX9s/lKQ SYeQbUjyCTJtnUB8/aY0dyPdkt/i89a+yqxI14jbJB9kg4jbikQSlOiGp8f2QFX75O3n 22c6vP0EoZkOFAxQ0m0upq3DIk/UFOKUB4zDc= MIME-Version: 1.0 Received: by 10.224.216.1 with SMTP id hg1mr1816901qab.179.1314049194673; Mon, 22 Aug 2011 14:39:54 -0700 (PDT) Received: by 10.224.178.65 with HTTP; Mon, 22 Aug 2011 14:39:54 -0700 (PDT) In-Reply-To: <20110822213549.GC4452@michelle.cdnetworks.com> References: <20110821234856.GB1755@michelle.cdnetworks.com> <20110822204054.GB4452@michelle.cdnetworks.com> <20110822213549.GC4452@michelle.cdnetworks.com> Date: Mon, 22 Aug 2011 14:39:54 -0700 Message-ID: From: Garrett Cooper To: pyunyh@gmail.com Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: mdf@freebsd.org, FreeBSD Current , Pyun YongHyeon Subject: Re: Deterministic panic due to non-sleepable lock with if_alc when reconfiguring interfaces X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Aug 2011 21:39:56 -0000 On Mon, Aug 22, 2011 at 2:35 PM, YongHyeon PYUN wrote: > On Mon, Aug 22, 2011 at 02:26:47PM -0700, Garrett Cooper wrote: >> On Mon, Aug 22, 2011 at 1:40 PM, YongHyeon PYUN wrote= : >> > On Sun, Aug 21, 2011 at 04:48:56PM -0700, YongHyeon PYUN wrote: >> >> On Fri, Aug 19, 2011 at 12:17:12AM -0700, Garrett Cooper wrote: >> >> > On Thu, Aug 18, 2011 at 9:31 PM, ? wrote: >> >> > > On Thu, Aug 18, 2011 at 5:50 PM, Garrett Cooper wrote: >> >> > >> ? ?When loading if_alc as a module on my netbook and running >> >> > >> /etc/rc.d/netif restart, I can deterministically panic my netboo= k with >> >> > >> the following message: >> >> > >> >> > ? ? These repro steps were overly simplified. The complete steps ar= e: >> >> > >> >> > 1. Attach ethernet cable to alc(4) enabled NIC. >> >> > 2. Boot up machine. >> >> > 3. Login. >> >> > 4. Physically remove ethernet cable from alc(4) enabled NIC. >> >> > 5. Run `/etc/rc.d/netif restart' as root. >> >> > >> >> >> >> I can't reproduce this with AR8151 sample board. Could you give me >> >> dmesg output to know exact controller revision? >> >> One issue I'm aware of is lack of re-establishing link when >> >> controller firmware put its PHY to deep sleep mode. ?The deep sleep >> >> mode seems to be automatically activated by firmware when it >> >> detects no energy signal(i.e. cable unplugged) so I had to down and >> >> up the interface again to take the PHY out of the sleep mode. >> >> >> > >> > Not re-establishing link issue was fixed in r225088. ?I'm not sure >> > whether this also fixes kern/148772 though. Because you also seem >> > to have the same issue of the PR, it would be good to know whether >> > it makes any difference or not. >> >> =A0 =A0 The panic no longer occurs with that commit when running >> /etc/rc.d/netif restart after inserting and reinserting the ethernet >> cable (I've done it several times for good measure); the failing case >> was potentially being triggered somehow by the hibernation code path. > > Hmm, have no idea how this can be related with the panic. :-( > BTW, does the commit also fix kern/148772? Yup. -Garrett