From owner-freebsd-current@FreeBSD.ORG  Tue Jan 20 21:28:33 2009
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 337BC106566C
	for <freebsd-current@FreeBSD.org>; Tue, 20 Jan 2009 21:28:33 +0000 (UTC)
	(envelope-from christoph.mallon@gmx.de)
Received: from mail.gmx.net (mail.gmx.net [213.165.64.20])
	by mx1.freebsd.org (Postfix) with SMTP id 76A5A8FC08
	for <freebsd-current@FreeBSD.org>; Tue, 20 Jan 2009 21:28:32 +0000 (UTC)
	(envelope-from christoph.mallon@gmx.de)
Received: (qmail invoked by alias); 20 Jan 2009 21:28:31 -0000
Received: from p54A3DE90.dip.t-dialin.net (EHLO tron.homeunix.org)
	[84.163.222.144]
	by mail.gmx.net (mp017) with SMTP; 20 Jan 2009 22:28:31 +0100
X-Authenticated: #1673122
X-Provags-ID: V01U2FsdGVkX1+bufkaKhWbKe7VeqcBfJwrrRNZAOsWu/UDY6NRdm
	XScvpCXtqN9RBL
Message-ID: <497641FC.30209@gmx.de>
Date: Tue, 20 Jan 2009 22:28:28 +0100
From: Christoph Mallon <christoph.mallon@gmx.de>
User-Agent: Thunderbird 2.0.0.19 (X11/20090103)
MIME-Version: 1.0
To: Giorgos Keramidas <keramida@FreeBSD.org>
References: <87skndg0cv.fsf@kobe.laptop>
In-Reply-To: <87skndg0cv.fsf@kobe.laptop>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-Y-GMX-Trusted: 0
X-FuHaFi: 0.5600000000000001
Cc: freebsd-current@FreeBSD.org, Tim Kientzle <kientzle@FreeBSD.org>
Subject: Re: [PATCH] bsdcpio core dump
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 20 Jan 2009 21:28:33 -0000

Giorgos Keramidas schrieb:
> diff -r cb9a95f8dfb3 usr.bin/cpio/cpio.c
> --- a/usr.bin/cpio/cpio.c	Tue Jan 20 21:45:52 2009 +0200
> +++ b/usr.bin/cpio/cpio.c	Tue Jan 20 22:56:48 2009 +0200
> @@ -623,12 +623,12 @@
>  	r = archive_write_header(cpio->archive, entry);
>  
>  	if (r != ARCHIVE_OK)
> -		cpio_warnc(archive_errno(cpio->archive),
> +		cpio_warnc(0,
>  		    "%s: %s",
> -		    destpath,
> +		    srcpath,
>  		    archive_error_string(cpio->archive));
>  

Wouldn't it be better to remove the manually appended error string, i.e. 
": %s" ... archive_error_string(), instead of circumventing the generic 
error reporting magic provided by cpio_warnc()?