From owner-dev-commits-src-all@freebsd.org Sun Feb 28 02:29:58 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 1752155DB16; Sun, 28 Feb 2021 02:29:58 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4Dp6mj4z1nz4k2t; Sun, 28 Feb 2021 02:29:57 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.16.1/8.16.1) with ESMTPS id 11S2TnJ4082146 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Sun, 28 Feb 2021 04:29:52 +0200 (EET) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua 11S2TnJ4082146 Received: (from kostik@localhost) by tom.home (8.16.1/8.16.1/Submit) id 11S2TnMf082145; Sun, 28 Feb 2021 04:29:49 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Sun, 28 Feb 2021 04:29:49 +0200 From: Konstantin Belousov To: Rick Macklem Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 3fe2c68ba20f - main - nfsclient: fix panic in cache_enter_time() Message-ID: References: <202102280156.11S1uhD3076969@gitrepo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202102280156.11S1uhD3076969@gitrepo.freebsd.org> X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FROM, NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on tom.home X-Rspamd-Queue-Id: 4Dp6mj4z1nz4k2t X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 Feb 2021 02:29:58 -0000 On Sun, Feb 28, 2021 at 01:56:43AM +0000, Rick Macklem wrote: > The branch main has been updated by rmacklem: > > URL: https://cgit.FreeBSD.org/src/commit/?id=3fe2c68ba20fb3365ef91e0b85f88237b5369f38 > > commit 3fe2c68ba20fb3365ef91e0b85f88237b5369f38 > Author: Rick Macklem > AuthorDate: 2021-02-28 01:54:05 +0000 > Commit: Rick Macklem > CommitDate: 2021-02-28 01:54:05 +0000 > > nfsclient: fix panic in cache_enter_time() > > Juraj Lutter (otis@) reported a panic "dvp != vp not true" in > cache_enter_time() called from the NFS client's nfsrpc_readdirplus() > function. > This is specific to an NFSv3 mount with the "rdirplus" mount > option. Unlike NFSv4, NFSv3 replies to ReaddirPlus > includes entries for the current directory. Should we check cache_enterXXX() args for other places, like lookup, as well? Malicious or buggy server could return the vp == dvp even for case other than dot. BTW, for some cases, dotdot can result in dvp == vp as well.