From owner-cvs-all@FreeBSD.ORG  Sun Apr 17 03:26:20 2005
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id F3AF816A4CE; Sun, 17 Apr 2005 03:26:19 +0000 (GMT)
Received: from VARK.MIT.EDU (VARK.MIT.EDU [18.95.3.179])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 92A6443D45; Sun, 17 Apr 2005 03:26:19 +0000 (GMT)
	(envelope-from das@FreeBSD.ORG)
Received: from VARK.MIT.EDU (localhost [127.0.0.1])
	by VARK.MIT.EDU (8.13.3/8.13.1) with ESMTP id j3H3QI3i018937;
	Sat, 16 Apr 2005 23:26:18 -0400 (EDT)
	(envelope-from das@FreeBSD.ORG)
Received: (from das@localhost)
	by VARK.MIT.EDU (8.13.3/8.13.1/Submit) id j3H3QIif018932;
	Sat, 16 Apr 2005 23:26:18 -0400 (EDT)
	(envelope-from das@FreeBSD.ORG)
Date: Sat, 16 Apr 2005 23:26:18 -0400
From: David Schultz <das@FreeBSD.ORG>
To: Mike Silbersack <silby@silby.com>
Message-ID: <20050417032618.GA65952@VARK.MIT.EDU>
Mail-Followup-To: Mike Silbersack <silby@silby.com>,
	src-committers@FreeBSD.ORG, cvs-src@FreeBSD.ORG, cvs-all@FreeBSD.ORG
References: <200504162347.j3GNlJUA010418@repoman.freebsd.org>
	<20050416195710.K756@odysseus.silby.com> <20050417014050.GA640@VARK.MIT.EDU>
	<20050416212457.V756@odysseus.silby.com>
	<20050416213839.A694@odysseus.silby.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20050416213839.A694@odysseus.silby.com>
cc: cvs-src@FreeBSD.ORG
cc: src-committers@FreeBSD.ORG
cc: cvs-all@FreeBSD.ORG
Subject: Re: cvs commit: src/sys/fs/msdosfs msdosfs_lookup.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 17 Apr 2005 03:26:20 -0000

On Sat, Apr 16, 2005, Mike Silbersack wrote:
> 
> On Sat, 16 Apr 2005, Mike Silbersack wrote:
> 
> >>I assume you mean that it *was* broken, until just now.  ;-)  Right?
> >
> >Oh, I cvsup'd and I thought I had grabbed the new version of the file, but 
> >it turns out that the cvsup server wasn't exactly up to date, so I grabbed 
> >a rev of it slightly newer than the one I had, but not the newest.
> >
> >So, I assume it's fixed now, I'll cvsup and doublecheck. :)
> >
> >Mike "Silby" Silbersack
> 
> Yeah, looks good now.  Sorry about the confusion.

Cool.  By the way, if you want to come up with a better fix,
please feel free.  I think the right fix is along the lines of:

	int msdosfs_vop_lookup(dvp, vpp, cnp) {
		do the usual checks (dvp is VDIR, R/O FS, VOP_ACCESS(dvp));
		char *oldname = cnp->cn_name;
		char newname[12] = unix2dosfn(oldname);
		cnp->cn_name = newname;
		error = cache_lookup(dvp, vpp, cnp);
		cnp->cn_name = oldname;
		if (error /* i.e., in cache */)
			return (error);
		return (msdosfs_lookup(dvp, vpp, cnp));
	}

I don't use msdosfs enough to adequately test this, though.