From owner-freebsd-ports-bugs@FreeBSD.ORG Sat Aug 23 21:02:34 2014 Return-Path: Delivered-To: freebsd-ports-bugs@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id CB46C61C for ; Sat, 23 Aug 2014 21:02:34 +0000 (UTC) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 997563D99 for ; Sat, 23 Aug 2014 21:02:34 +0000 (UTC) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id s7NL2Y9E090644 for ; Sat, 23 Aug 2014 21:02:34 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 192561] [NEW PORT] misc/virtualgl - VirtualGL Date: Sat, 23 Aug 2014 21:02:34 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports Tree X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: davidjx8p@gmail.com X-Bugzilla-Status: In Discussion X-Bugzilla-Priority: Normal X-Bugzilla-Assigned-To: freebsd-ports-bugs@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Aug 2014 21:02:34 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=192561 --- Comment #7 from David Mackay --- (In reply to Adam Weinberger from comment #6) > I've split apart libjpeg-turbo for you, so this port can depend on it > instead of repackaging it. > > That said, this port does some weird stuff. Why does it depend on libtool, > automake, and autoreconf if it uses cmake? Why is it installing everything > under a different PREFIX rather than putting things in the usual locations? > Why have you used spaces instead of tabs after variable names in the > Makefile? > > Please work through those issues, run the port through portlint, and submit > an updated version. > > I know you've put a lot of work into these ports, and I'm trying to help you > tighten them up so we can get it committed. Hiya, I hadn't noticed the dependencies on the GNU build suite. What I did once was build libjpeg-turbo as part of this port. I'll just clear those since they no longer apply. Likewise I hadn't noticed the spaces - perhaps my editor is doing this. As for the PREFIX, that's conditionally set as VirtualGL has to be installed under its own prefix, since its installed files will collide with other sources of libGL.so, and it expects its own prefix. I'll see if I can find a cleaner way to handle the setting of prefix - unfortunately, cmake has been proving difficult to work with. Anyway - thanks for the feedback, and I'll try and sort out these issues within an hour or two. -- You are receiving this mail because: You are the assignee for the bug.