From owner-svn-src-head@freebsd.org Mon Feb 27 02:25:07 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5A962CEFBC9 for ; Mon, 27 Feb 2017 02:25:07 +0000 (UTC) (envelope-from pfg@FreeBSD.org) Received: from nm24-vm5.bullet.mail.ne1.yahoo.com (nm24-vm5.bullet.mail.ne1.yahoo.com [98.138.91.246]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 2E2C86EB for ; Mon, 27 Feb 2017 02:25:07 +0000 (UTC) (envelope-from pfg@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1488162300; bh=QkSAuYh9EezaIEA6B+okQ3V7KQDY8qGRln1rSIyA4o4=; h=Subject:To:References:Cc:From:Date:In-Reply-To:From:Subject; b=sit4VGIvjqU77MeOmi35OhDUfNlvRE3vHqoKbKHaiMtHfLrZTCfA6dxhonGeml6buM0jPBsMUVEctXEbz7/+vVCgv+ioBAPUrJE0q6fH2ZpQhBo0W/2+aX2OxIqdRXnj+EFvO8dtOY8ZdUUPZR1dIS/3czf/DF0SUIWl58phoAFclKBJXLcQp6cz3hy/WsAKElWdQ1N57OVrNHQwwbG/U35QSrK+kSQG4uN93XbKTYXtXRqC0RhLdyrIKZwzfVLgo50bsZTuLZiSkhYg5GvirIncPMExm2AuFkCyQDfxSIA4p7Ap4oYy5g0AiHfOfA9lk1tiXVJt5qqGmWnrtmbsZw== Received: from [98.138.100.118] by nm24.bullet.mail.ne1.yahoo.com with NNFMP; 27 Feb 2017 02:25:00 -0000 Received: from [98.138.84.39] by tm109.bullet.mail.ne1.yahoo.com with NNFMP; 27 Feb 2017 02:25:00 -0000 Received: from [127.0.0.1] by smtp107.mail.ne1.yahoo.com with NNFMP; 27 Feb 2017 02:25:00 -0000 X-Yahoo-Newman-Id: 743187.11294.bm@smtp107.mail.ne1.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: Pveaq5IVM1lNQO49Uhedk6qmKv0D2jDrW0s0o0Fuke_hCFW _UqKS6FvFliSWrr.ezJtk.OALGywvAxjx46K_0vX5ldnhZDWkJSruhejVIvq H7WQAaRDtayyI.7VbksevhA3DoJurPpbMhhQ3E6D.gNJaBwrqwN1uwtUnuuY _mlq3..CnuXwPj3pHgKHlRfAu3k4.Sk3XZuYYYrQwGvHeSVo1iCoLgNgccVN bwCqSnpl2NBN1f8SvBGjNmmpc2me_CKrtPYpUep0kTZXrAOqDwftK8NrYh07 yB7uIDARdfeU85IETxvgQTjMX8Bs7GxtA8oWzG6sP073IEtq6Z0VwgHuqU4b IwvXRsUKQzPmV5ALmReh2YmpGlWx8YUbWWPyq_uRf748qsiGevyI1BX88XUm mw5gaoU9AP_D9kiQBHCTH8Lkfp5fBcmowzD90ljTMu2MH8Kr3tMHvx3D9wm6 vLGW6idnCbihLFtioMQQX9O0YUfqTqB7fSm2qfQhNebuB9m7jm2NnyDkweup m5wDX7EfsH_0kXF_5URMGN9sviEc31bKepYQzhR6zxpYBGWo- X-Yahoo-SMTP: xcjD0guswBAZaPPIbxpWwLcp9Unf Subject: Re: svn commit: r314322 - head/lib/librss To: Cy Schubert References: <201702270151.v1R1pe1F003587@slippy.cwsent.com> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org From: Pedro Giffuni Message-ID: <404d743b-735b-0605-5ab5-ccb95ce24ad8@FreeBSD.org> Date: Sun, 26 Feb 2017 21:27:48 -0500 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <201702270151.v1R1pe1F003587@slippy.cwsent.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Feb 2017 02:25:07 -0000 Hello; On 2/26/2017 8:51 PM, Cy Schubert wrote: > In message <201702270010.v1R0A1wm074123@repo.freebsd.org>, "Pedro F. > Giffuni" w > rites: >> Author: pfg >> Date: Mon Feb 27 00:10:00 2017 >> New Revision: 314322 >> URL: https://svnweb.freebsd.org/changeset/base/314322 >> >> Log: >> librss: simplify some NULL checks. >> >> MFC after: 1 week >> >> Modified: >> head/lib/librss/librss.c >> >> Modified: head/lib/librss/librss.c >> ============================================================================= >> = >> --- head/lib/librss/librss.c Sun Feb 26 22:17:06 2017 (r314321) >> +++ head/lib/librss/librss.c Mon Feb 27 00:10:00 2017 (r314322) >> @@ -244,10 +244,10 @@ rss_config_get(void) >> return (rc); >> >> error: >> - if ((rc != NULL) && rc->rss_bucket_map) >> + if (rc != NULL) { >> free(rc->rss_bucket_map); > What happens if rc is not NULL and rc->rss_bucket_map is NULL? According the free(3): " If /ptr/ is *NULL*, no action occurs." Pedro.