Date: Sun, 27 Mar 2011 19:02:57 +0300 From: "Y. A." <nexther0@gmail.com> To: Evan Martin <evan@chromium.org> Cc: freebsd-chromium@freebsd.org Subject: Re: fixes for Makefile pkg-plist and build-in ffmpeg Message-ID: <AANLkTinGtOoZdnBwLPNu8rrDXD9B=T-picLUf6hmnYAv@mail.gmail.com> In-Reply-To: <AANLkTinwj5RrkLdEPSSDa4vTFVUFL6e95tDi2ZOikTuN@mail.gmail.com> References: <AANLkTik5FbEcH8nB2SUtHNZYiLnaSVF1x1HmjcW0baO2@mail.gmail.com> <AANLkTimrOiK=e01-doqC8jJuOaXyZ6dni8Ngk8b1AmYK@mail.gmail.com> <BANLkTimn8joDX%2Bv3Zz%2BJ04p0SPQCKPeLOw@mail.gmail.com> <AANLkTikoBu5GEKSRNQPjVofrZ5WOj=nR%2BcTkA26mrLNF@mail.gmail.com> <AANLkTinwj5RrkLdEPSSDa4vTFVUFL6e95tDi2ZOikTuN@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
hi!
for me on CURRENT is look ok. but i think we need more testing.
2011/3/27 Evan Martin <evan@chromium.org>
> On Sun, Mar 27, 2011 at 5:36 PM, Y. A. <nexther0@gmail.com> wrote:
> > +--- third_party/ffmpeg/ffmpeg.gyp.orig 2011-03-23 10:02:47.000000000
> +0200
> > ++++ third_party/ffmpeg/ffmpeg.gyp 2011-03-27 15:07:20.000000000
> +0300
> > +@@ -56,7 +56,7 @@
> > + ['target_arch=="arm"', {
> > + 'ffmpeg_asm_lib': 0,
> > + }],
> > +- ['OS=="mac" or OS=="win"', {
> > ++ ['OS=="mac" or OS=="win" or OS=="freebsd"', {
> > + 'os_config%': '<(OS)',
> > + }, { # all other Unix OS's use the linux config
> > + 'os_config%': 'linux',
> > +@@ -82,7 +82,7 @@
>
> I'd be happy to take a patch like this upstream if you think it's correct.
> If Linux is the special case, then perhaps simplifying the test to
> just 'OS!="linux"' (and fixing the comment below) might be nice.
>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?AANLkTinGtOoZdnBwLPNu8rrDXD9B=T-picLUf6hmnYAv>