Date: Sun, 22 Jul 2001 22:27:10 -0400 From: Garance A Drosihn <drosih@rpi.edu> To: Assar Westerlund <assar@FreeBSD.org> Cc: Brian Somers <brian@Awfulhak.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libutil ecalloc.c emalloc.3 emalloc.c erealloc.c estrdup.c Makefile libutil.h Message-ID: <p0510101fb78134160082@[128.113.24.47]> In-Reply-To: <200107230137.f6N1bfg13122@hak.lan.Awfulhak.org> References: <200107230137.f6N1bfg13122@hak.lan.Awfulhak.org>
next in thread | previous in thread | raw e-mail | index | archive | help
At 2:37 AM +0100 7/23/01, Brian Somers wrote: >Assar Westerlund <assar@FreeBSD.org> wrote: > > Why is this bizarre? Is it better having these functions in lots > > of different programs under different names? I sent a mail about > > this to freebsd-audit@freebsd.org. > >Adding routines such as these to our libraries and then using them >from our programs just makes it irritating when you try to build >something on another OS -- not to mention obfuscating our code base. > >Of course I completely disagree with the err/errx/warn/warnx stuff >too for exactly the same reasons -- having wanted to build things >such as newsyslog to Solaris. I pick up freebsd's code for lpr and recompile it on a number of other platforms. In that context I do find that the addition of all these "little routines" as "standard system routines" gets a little frustrating when porting things. If we were going to add these, then perhaps it should be by adding a 'x' at the end of the name, instead of an 'e' at the start. The message that you posted to -audit just said "Any comments?" along with the patch. I assumed that meant that the IDEA of adding these routines had been discussed somewhere else, and that you were just looking for someone to AUDIT the specific code you had written to do it. I wouldn't say that I actually object to adding the routines, but I'm not particularly thrilled with the idea either. I do not think it is necessarily a good idea to add a new routine to the system libraries every time we find four lines of code which appear in multiple programs. All of the above are just my opinions, and not even strongly-held opinions at that... -- Garance Alistair Drosehn = gad@eclipse.acs.rpi.edu Senior Systems Programmer or gad@freebsd.org Rensselaer Polytechnic Institute or drosih@rpi.edu To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?p0510101fb78134160082>