From nobody Wed Mar 15 03:20:32 2023 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PbwdD4wkNz3xtxB for ; Wed, 15 Mar 2023 03:20:32 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PbwdD2Tjmz3G82 for ; Wed, 15 Mar 2023 03:20:32 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1678850432; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=z8Kd9BGwUmYq5C4yetZuYnCQH9rJdPJaBohnfR32XYo=; b=tRrdtlNhMjeq3NsSWojUNKCdeXDclRnU37FScX5xjrhxFMvNPxKTyPASRkBoxhpLJgHrkW eJq1mBQvlbeqTACdzThaTz9YNyKJTJlo8e4A0cNE3IZKd3mTC4Ryxh/5nawVaDg0rssm44 VCveNDgsnGwjDLhMQgBl6Tv+C1wc5N8j8BZ0nR+BAz6oLJgq4gLXOdcjzS2+QK0jRi1uc0 tzSvXgiRCQoEQ+SUqUVRXMiCO2qAA334DV4I2JgqzVhAZ/uo1SFoY0hmXmdmZ8A+kZA6he R14XkV3KceJBZOIyBZrwEhfhAXM6bR/y+OQf0cNRMau21kfFeRkubtj6Fkw7dQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1678850432; a=rsa-sha256; cv=none; b=lqtl8HHk+7Ymmn2g7Fqaq3H5AzayWRD0pgoTMMSJ3t5UECLwCwx1BM64Fp+bxroV2v6FqO dshwVB3w/wmJTxhIoPokDVKsLfldcz/HCaCHKtfKC+WY9fSM0PVONnkAIC2F8hcGMmAdfD zmn3hO4SWwOt7obCm39KTxnSPuINyuvcf40vMJpDDyGMWqmgXrdiwBYlWGo7BjjBHcV9b9 lpvbO+a4dTS8zRrOUkKb2j82yJipzhcHxZTMHbP0uhWsOVCKRJNbh+qZ+ZbllwPi1M6lUc CHe3OG7Q2SWEvbH7JwxieomHXzByoUqBptGd2Gq/w3Wq8tQxYonDF6BS6tXMUw== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4PbwdD1bJwz11cr for ; Wed, 15 Mar 2023 03:20:32 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 32F3KW7W011120 for ; Wed, 15 Mar 2023 03:20:32 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 32F3KWsT011119 for bugs@FreeBSD.org; Wed, 15 Mar 2023 03:20:32 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 265248] bectl warns twice when the user tries once to create an existing environment (boot environment name already taken) Date: Wed, 15 Mar 2023 03:20:32 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D265248 --- Comment #2 from commit-hook@FreeBSD.org --- A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3D8e933d9c598ec847081c322e7ae9a46bf= 7897886 commit 8e933d9c598ec847081c322e7ae9a46bf7897886 Author: John Grafton AuthorDate: 2023-03-15 03:14:14 +0000 Commit: Warner Losh CommitDate: 2023-03-15 03:15:17 +0000 libbe: Avoid double printing cloning errors. be_clone calls be_clone_cb and both call set_error on the return error path. set_error prints the error resulting in a double print. be_clone_cb should just return the error code and allow be_clone to print it. PR: 265248 Reported by: Graham Perrin Reviewed by: imp, kevans Pull Request: https://github.com/freebsd/freebsd-src/pull/685 lib/libbe/be.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) --=20 You are receiving this mail because: You are the assignee for the bug.=