Date: Tue, 27 Jun 2000 18:39:27 +0200 (CEST) From: Sascha Schumann <sascha@schumann.cx> To: Leonard den Ottolander <leonardjo@hetnet.nl> Cc: freebsd-fs@freebsd.org Subject: Re: Again:Patch concerning linux extended fs Message-ID: <Pine.LNX.4.21.0006271836370.25165-100000@eco.foo> In-Reply-To: <08ac62449131b60NET015S@hetnet.nl>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 27 Jun 2000, Leonard den Ottolander wrote:
> Hi Sascha,
>
> > Instead of changing all checks everytime, you might want to
> > use a macro:
> >
> > #define IS_DOS_EXTENDED_PARTITION(n) \
> > (n == DOSPTYP_EXTENDED \
> > || n == DOSPTYP_EXTENDEDX \
> > || n == DOSPTYP_LINUXEXTENDED)
>
> If you check the Linux fdisk.h (fe util-linux 2.9w), you will see that they
> indeed use a very similair (almost identical) macro. One thing though, it is
> more correct to put braces around the n's, in case (n) is a compound element.
> This should actually be done in any macro, to prevent errors.
> You could of course have submitted this to the list yourself, since it is not
> just my concern! I will include it before I do a PR submission.
Imagine, if I had sent you the most perfect macro. You would
have to do nothing but to include it in your code. That is
not really satisfying, isn't it. :-)
(I did not really follow the thread, so the author of the
patch might have been someone else.)
- Sascha
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-fs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.LNX.4.21.0006271836370.25165-100000>