From owner-svn-src-head@freebsd.org Sun Jun 4 23:47:32 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B8A9EBF296D; Sun, 4 Jun 2017 23:47:32 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 83F3A6593F; Sun, 4 Jun 2017 23:47:32 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (unknown [127.0.1.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by freefall.freebsd.org (Postfix) with ESMTPS id BEAA71939C; Sun, 4 Jun 2017 23:47:31 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [172.31.3.2]) by mail.xzibition.com (Postfix) with ESMTP id C8C04790A; Sun, 4 Jun 2017 23:47:30 +0000 (UTC) X-Virus-Scanned: amavisd-new at mail.xzibition.com Received: from mail.xzibition.com ([172.31.3.2]) by mail.xzibition.com (mail.xzibition.com [172.31.3.2]) (amavisd-new, port 10026) with LMTP id FyKJ6JB2SNul; Sun, 4 Jun 2017 23:47:26 +0000 (UTC) Subject: Re: svn commit: r319507 - head/sys/fs/msdosfs DKIM-Filter: OpenDKIM Filter v2.9.2 mail.xzibition.com 568AC7905 To: Ed Maste References: <201706021839.v52IdrZJ074478@repo.freebsd.org> <20170603161546.D939@besplex.bde.org> <543a4144-4f08-8742-5455-0103569d9f4f@FreeBSD.org> Cc: Bruce Evans , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" From: Bryan Drewery Organization: FreeBSD Message-ID: <721fdeb3-b9d6-b8f4-9025-a5ae7bfd295f@FreeBSD.org> Date: Sun, 4 Jun 2017 16:47:24 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="62JFGPNpKQd3c3D4qgRjPnW5AVMoO3Mk2" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 04 Jun 2017 23:47:32 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --62JFGPNpKQd3c3D4qgRjPnW5AVMoO3Mk2 Content-Type: multipart/mixed; boundary="1UMCgSx2OS3esbTr8SQ4GT6aI4UTSi6x3"; protected-headers="v1" From: Bryan Drewery To: Ed Maste Cc: Bruce Evans , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Message-ID: <721fdeb3-b9d6-b8f4-9025-a5ae7bfd295f@FreeBSD.org> Subject: Re: svn commit: r319507 - head/sys/fs/msdosfs References: <201706021839.v52IdrZJ074478@repo.freebsd.org> <20170603161546.D939@besplex.bde.org> <543a4144-4f08-8742-5455-0103569d9f4f@FreeBSD.org> In-Reply-To: --1UMCgSx2OS3esbTr8SQ4GT6aI4UTSi6x3 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 6/4/17 4:27 PM, Ed Maste wrote: > On 4 June 2017 at 14:06, Bryan Drewery wrote: >> >> In r189170. It seems to me we should change systm.h back to a macro >> #define memmove(dst, src, len) bcopy((src), (dst), (len)) >=20 > Note that they're not quite equivalent: memmove returns dst, while > bcopy has no return value. >=20 #define memmove(dst, src, len) (bcopy((src), (dst), (len)), dst) Obscure comma operator, or we just add an inline memmove in systm.h too. --=20 Regards, Bryan Drewery --1UMCgSx2OS3esbTr8SQ4GT6aI4UTSi6x3-- --62JFGPNpKQd3c3D4qgRjPnW5AVMoO3Mk2 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQEcBAEBCgAGBQJZNJwNAAoJEDXXcbtuRpfPv7sH/3Iq4Fa5ov9NOQrZ6LbWEt4E cDdnl0CnS1qvkIwnuT4W+0Qiw+jd27E8N85oPMX4tPNnJTqC/d0IBFOcXKbFCNLg OQ/BMeCELonEs2MnK7enKI4QAiaVYQrhJu+cVyLrhuu/jkdodCWmoIf8K/jpNwoU 40CxNplBjaFk5twlI8jYYe1mxkqtVvvtcZ+D8jUBPmjMOThRP+G2U8jBBdtKsBBL r06mlGQin8+lquAlASxH7JpRWkxeUvjrjGVhaQmTYqPltTlxr025O+OinFt2JgeS wPVlXWXGCgX+L4sicd1ooLtRBJ5gxLjXxLapJilelZHWARLiQO3uatzUGn/BGtQ= =3JMT -----END PGP SIGNATURE----- --62JFGPNpKQd3c3D4qgRjPnW5AVMoO3Mk2--