From owner-svn-src-all@freebsd.org Fri Feb 24 14:22:25 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CA994CEBF17; Fri, 24 Feb 2017 14:22:25 +0000 (UTC) (envelope-from vangyzen@FreeBSD.org) Received: from smtp.vangyzen.net (hotblack.vangyzen.net [IPv6:2607:fc50:1000:7400:216:3eff:fe72:314f]) by mx1.freebsd.org (Postfix) with ESMTP id B3AC719ED; Fri, 24 Feb 2017 14:22:25 +0000 (UTC) (envelope-from vangyzen@FreeBSD.org) Received: from ford.home.vangyzen.net (unknown [76.164.15.242]) by smtp.vangyzen.net (Postfix) with ESMTPSA id DE42656483; Fri, 24 Feb 2017 08:22:24 -0600 (CST) Subject: Re: svn commit: r314179 - in head: contrib/netbsd-tests/lib/librt include lib/libc/gen lib/libc/include share/man/man3 sys/kern To: Ngie Cooper References: <201702231936.v1NJadRa029404@repo.freebsd.org> Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" From: Eric van Gyzen Message-ID: <31cd29ad-6c34-f3d0-b71c-04857b013d02@FreeBSD.org> Date: Fri, 24 Feb 2017 08:22:21 -0600 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Feb 2017 14:22:25 -0000 >> Modified: head/contrib/netbsd-tests/lib/librt/t_sem.c > > ... > > *sigh* I really wish people would read MAINTAINERS and include me on > CRs to contrib/netbsd-tests/ (especially since I spent a few weekends > cleaning this up to diff reduce and contribute back changes to > NetBSD). Drat. I totally failed to check MAINTAINERS. Sorry, Ngie. Thanks for reminding me. I welcome any feedback. I plan to contribute a variant this entire commit--or at least raise the idea--to the NetBSD folks. If that fails, I'll at least try to contribute/diff-reduce the unit test. By the way, have you considered adding a Herald rule on Phabricator? Phab is not perfect, but a lot of folks use it, and the Herald rules are a very effective way to watch them play in one's area. Cheers, Eric