From owner-svn-src-head@freebsd.org Sun Mar 12 18:41:50 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CB7EDD085CE; Sun, 12 Mar 2017 18:41:50 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pg0-x243.google.com (mail-pg0-x243.google.com [IPv6:2607:f8b0:400e:c05::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 9C3DF183E; Sun, 12 Mar 2017 18:41:50 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pg0-x243.google.com with SMTP id g2so11391230pge.2; Sun, 12 Mar 2017 11:41:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=10TIkoQsjViCO44T0saWVbB6TKSnl0AhlPe4nBv7dto=; b=ZUAm6mKTEuxr3ckzvDI3A3a6eY2CwZAki4RppLYW2BRLCpA/Kk8r5TuOotkIw9R9dZ 7A0i2c6eXsVaQMOrEWpu6gJfBsIkgjTXkHzqqf5fJk8xNoxqIWnY8CKn+rHXQr53DE2p pLuNVdhCaMnGv8SdhyQwtSTORkF/B+4ecQJlkf0HbhZ9QBZt5qrTmTH0pfhrccE93i9p ALqa8ebVUI/9SLp7DGkcdIBmor7nzs37Iz/4k0Y+yU1aeO9utm1kI0aLe6ZQbKBjiMkq hn0OD2ly4/H/1g0hzB5zmlqmSewwjkOpTrSh8fdsx/fAFsonAom8B3RgsqI3Ob4f2+Pn 1Kdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=10TIkoQsjViCO44T0saWVbB6TKSnl0AhlPe4nBv7dto=; b=MjxQLKAYIsO3jqp9eUXDqwde3/Ac3fzv/ZTeseFeT+KClcJGiP9xE3VBqKNjz8AVZh aE1HRRF8RKpcnH8+xzw54XM699X8zrNEIS9ohnwqCLN1gb4aqvGZBMDwG1e3wO17P5CH S+USzG0fQgCE5g3QtnxiPUpN4QRTURzR0q+ggDyJTujtF7JY1FsX8GpPPi5bH9w0F98k cwQJObHVkDgDU8OYh6aYeYIZ8UTdoKH192uIQW4fpwZDh5JGswqLLtWU/ZgNIQ6fEhQK LStwo006VePfA41J7C1zeYtYQgbLaRwgqoFI/EuEAmhfhTPMJFlobaGkylefCrdYdjOp 2wKQ== X-Gm-Message-State: AMke39lOtzddKJxZBdagdzBkY+I6PQb0ufWf6IiacSBp55HQphVSDuP51hdlyLCeeaqa7w== X-Received: by 10.99.54.7 with SMTP id d7mr23163656pga.186.1489344110043; Sun, 12 Mar 2017 11:41:50 -0700 (PDT) Received: from ?IPv6:2607:fb90:8117:a021:701c:cd2:10ac:ee5f? ([2607:fb90:8117:a021:701c:cd2:10ac:ee5f]) by smtp.gmail.com with ESMTPSA id n185sm29564569pga.9.2017.03.12.11.41.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 12 Mar 2017 11:41:49 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (1.0) Subject: Re: svn commit: r315164 - head/lib/libpam/modules/pam_exec From: Ngie Cooper X-Mailer: iPhone Mail (14D27) In-Reply-To: <201703121741.v2CHfpSA070217@repo.freebsd.org> Date: Sun, 12 Mar 2017 11:41:48 -0700 Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: References: <201703121741.v2CHfpSA070217@repo.freebsd.org> To: "Pedro F. Giffuni" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 12 Mar 2017 18:41:50 -0000 > On Mar 12, 2017, at 10:41, Pedro F. Giffuni wrote: >=20 > Author: pfg > Date: Sun Mar 12 17:41:51 2017 > New Revision: 315164 > URL: https://svnweb.freebsd.org/changeset/base/315164 >=20 > Log: > Revert r314780 > libpam: extra bounds checking through reallocarray(3). >=20 > It appears to be causing brokenness when reporting PAM_* environment > variables. This requires more investigation. >=20 > Reported by: lstewart >=20 > Modified: > head/lib/libpam/modules/pam_exec/pam_exec.c >=20 > Modified: head/lib/libpam/modules/pam_exec/pam_exec.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D > --- head/lib/libpam/modules/pam_exec/pam_exec.c Sun Mar 12 16:55:18 201= 7 (r315163) > +++ head/lib/libpam/modules/pam_exec/pam_exec.c Sun Mar 12 17:41:51 201= 7 (r315164) > @@ -138,7 +138,7 @@ _pam_exec(pam_handle_t *pamh __unused, > nitems =3D sizeof(env_items) / sizeof(*env_items); > /* Count PAM return values put in the environment. */ > nitems_rv =3D options->return_prog_exit_status ? PAM_RV_COUNT : 0; > - tmp =3D reallocarray(envlist, envlen + nitems + 1 + nitems_rv + 1, > + tmp =3D realloc(envlist, (envlen + nitems + 1 + nitems_rv + 1) * Eep. nitems variable use here too (masking nitems macro). -Ngie=