From owner-freebsd-wireless@FreeBSD.ORG Sun Dec 2 06:37:45 2012 Return-Path: Delivered-To: freebsd-wireless@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id AE8F17F4 for ; Sun, 2 Dec 2012 06:37:45 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-wi0-f174.google.com (mail-wi0-f174.google.com [209.85.212.174]) by mx1.freebsd.org (Postfix) with ESMTP id 357918FC08 for ; Sun, 2 Dec 2012 06:37:44 +0000 (UTC) Received: by mail-wi0-f174.google.com with SMTP id hm9so480356wib.13 for ; Sat, 01 Dec 2012 22:37:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:content-type; bh=gzi70b9NH0Da3RlI3oF+jmYxy7HWOXn4q4IW59VCvi4=; b=KAvXWXSzqSgUrziLmpYTU3ifCXJ50iSMyacZ/+GeLXZGB2z8dIKcl0EMkhOMaWqe9N J0VFjyqqZVkG0nN1JDamRb4cHfgBWIhxfIuMZRYCUbwnCQZF6H1qA3A/nnetcqHfTRaM N3z6makkr696e4L7+Mg2lYwJPLxn3bqdJid4g27IYPueP7pEuoYxtXT4nmKBgxzXIZUh Jr/kwh9jFYzT5xbnItWeFFYPkfFdOQOs5+xwQ7l0/rZl0dHDHStwQSyqnCXcgrASmrT2 6w72QqOgqOn0zmVhzYfEH9n0XAatn3hpvePgdOxVXiTGzUQGYEK8cktDBfk7EPiwlRn1 Eujw== MIME-Version: 1.0 Received: by 10.180.103.106 with SMTP id fv10mr4301113wib.19.1354430264037; Sat, 01 Dec 2012 22:37:44 -0800 (PST) Sender: adrian.chadd@gmail.com Received: by 10.217.57.9 with HTTP; Sat, 1 Dec 2012 22:37:43 -0800 (PST) In-Reply-To: References: Date: Sat, 1 Dec 2012 22:37:43 -0800 X-Google-Sender-Auth: niUumlF9kGSpsi5iYx2XY49ZYCo Message-ID: Subject: Re: Please test - collapsing the TX locking down to ATH_TX_LOCK() From: Adrian Chadd To: freebsd-wireless@freebsd.org Content-Type: text/plain; charset=ISO-8859-1 X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 02 Dec 2012 06:37:45 -0000 Hi, I've committed the patch, with an extra bugfix (recursive locking, eek.) I'm now going to go through and begin un-doing the couple of LORs I know will occur when ieee80211_free_node() is called whilst the TX lock is held. Please update to -HEAD and test thoroughly with WITNESS enabled. I'm going to make a big push now to simplify a lot of the locking in the TX path so I can squeeze some more TX performance out of the code. Thanks, Adrian