Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 26 Apr 2020 19:12:32 +0000
From:      bugzilla-noreply@freebsd.org
To:        ports-bugs@FreeBSD.org
Subject:   [Bug 239774] [NEW PORT] audio/playumidi Standard MIDI format 0/1 player for FreeBSD USB-MIDI(umidi) device
Message-ID:  <bug-239774-7788-GGXnuSJwZp@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-239774-7788@https.bugs.freebsd.org/bugzilla/>
References:  <bug-239774-7788@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D239774

--- Comment #4 from daniel.engberg.lists@pyret.net ---
Hi,

Much better now, I did however notice that the archive includes a license f=
ile
which you should have in your Makefile

https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/licenses=
.html
LICENSE_FILE=3D   ${WRKSRC}/LICENSE

While at it, minor style fix but you can also drop the # libiconv and debug
lines. Your Makefile is so small so you can easily get a good overview of it
even without those comments.

Apart from those changes it looks ready to be committed as far as I can tel=
l.

Best regards,
Daniel

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-239774-7788-GGXnuSJwZp>