From owner-cvs-all@FreeBSD.ORG Sun Jul 6 23:03:23 2003 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 16C8537B401; Sun, 6 Jul 2003 23:03:23 -0700 (PDT) Received: from HAL9000.homeunix.com (ip114.bella-vista.sfo.interquest.net [66.199.86.114]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1C27E43FAF; Sun, 6 Jul 2003 23:03:22 -0700 (PDT) (envelope-from das@FreeBSD.ORG) Received: from HAL9000.homeunix.com (localhost [127.0.0.1]) by HAL9000.homeunix.com (8.12.9/8.12.9) with ESMTP id h6763JK5028505; Sun, 6 Jul 2003 23:03:19 -0700 (PDT) (envelope-from das@FreeBSD.ORG) Received: (from das@localhost) by HAL9000.homeunix.com (8.12.9/8.12.9/Submit) id h6763I6s028504; Sun, 6 Jul 2003 23:03:18 -0700 (PDT) (envelope-from das@FreeBSD.ORG) Date: Sun, 6 Jul 2003 23:03:18 -0700 From: David Schultz To: David Xu Message-ID: <20030707060318.GA28281@HAL9000.homeunix.com> Mail-Followup-To: David Xu , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org References: <200307070428.h674SNfq092785@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200307070428.h674SNfq092785@repoman.freebsd.org> cc: cvs-src@FreeBSD.ORG cc: src-committers@FreeBSD.ORG cc: cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/lib/libpthread/thread thr_attr_get_np.c thr_cancel.c thr_getschedparam.c thr_join.c thr_mutex_prioceiling.c thr_sigaction.c thr_sigmask.c thr_sigpending.c thr_sigsuspend.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jul 2003 06:03:23 -0000 On Sun, Jul 06, 2003, David Xu wrote: > davidxu 2003/07/06 21:28:23 PDT > > FreeBSD src repository > > Modified files: > lib/libpthread/thread thr_attr_get_np.c thr_cancel.c > thr_getschedparam.c thr_join.c > thr_mutex_prioceiling.c thr_sigaction.c > thr_sigmask.c thr_sigpending.c > thr_sigsuspend.c > Log: > Avoid accessing user provided parameters in critical region. Cool. What happens if a page fault is taken in a critical region? Does this merely make the KSE unusable by other threads until the page is faulted in, or does it deadlock the UTS? (If the latter is true, you'd need to wire a stack page or two to ensure correctness, or do soemthing differently.)