From owner-cvs-all Mon Sep 23 0:42:29 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AA0B137B401; Mon, 23 Sep 2002 00:42:28 -0700 (PDT) Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6652843E6E; Mon, 23 Sep 2002 00:42:27 -0700 (PDT) (envelope-from bde@zeta.org.au) Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102]) by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id RAA09984; Mon, 23 Sep 2002 17:42:24 +1000 Date: Mon, 23 Sep 2002 17:51:17 +1000 (EST) From: Bruce Evans X-X-Sender: bde@gamplex.bde.org To: Peter Wemm Cc: cvs-committers@FreeBSD.org, Subject: Re: cvs commit: src/sys/sys cdefs.h In-Reply-To: <200209230637.g8N6bs92050122@freefall.freebsd.org> Message-ID: <20020923174125.O16983-100000@gamplex.bde.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Sun, 22 Sep 2002, Peter Wemm wrote: > peter 2002/09/22 23:37:51 PDT > > Modified files: > sys/sys cdefs.h > Log: > Alfred got me thinking. Provide stubs for lint, and let the compilers > themselves cause a failure if it is told to use a __widget that there is > no implementation for them. missing an implementation for __unused etc is > harmless. But not having a __packed implementation when the kernel code > really needs it is a big deal. > > Revision Changes Path > 1.66 +11 -5 src/sys/sys/cdefs.h Providing stubs for lint is wrong when the non-stubs affects the semantics of the program, as they do for the new attributes both not for most of the old ones. Lint should fail in the same way as the compiler that it is linting for, and there must be no ifdefs for lint in cdefs.h (`lint' is in the application namespace, so it must not affect any standard header). A lint that lints gcc code must obviously declare __GNUC__ and __GNUC_MINOR__ for the version of gcc that it supports, since otherwise it would not see the same things as that version of gcc. Style bugs in revs 1.63-1.66: the new definitions are unsorted. Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message