From owner-svn-src-all@freebsd.org Mon Jun 20 15:31:58 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 91889AC4AD2; Mon, 20 Jun 2016 15:31:58 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: from venus.codepro.be (venus.codepro.be [IPv6:2a01:4f8:162:1127::2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "*.codepro.be", Issuer "Gandi Standard SSL CA 2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 27B471EB6; Mon, 20 Jun 2016 15:31:58 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: from [150.158.232.236] (114.40-78-194.adsl-static.isp.belgacom.be [194.78.40.114]) (Authenticated sender: kp) by venus.codepro.be (Postfix) with ESMTPSA id 1CABA1E03E; Mon, 20 Jun 2016 17:31:56 +0200 (CEST) From: "Kristof Provost" To: "Alan Somers" Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Subject: Re: svn commit: r300881 - in head/sys: cddl/contrib/opensolaris/uts/common/fs/zfs geom Date: Mon, 20 Jun 2016 17:31:54 +0200 Message-ID: In-Reply-To: References: <201605272232.u4RMWjku087648@repo.freebsd.org> MIME-Version: 1.0 X-Mailer: MailMate (1.9.4r5234) Content-Type: text/plain; charset=utf-8; format=flowed; markup=markdown Content-Transfer-Encoding: 8bit X-Content-Filtered-By: Mailman/MimeDel 2.1.22 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Jun 2016 15:31:58 -0000 No, it’s an HP Microserver. 4 data disks and that’s it. Bug: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=210409 Regards, Kristof On 20 Jun 2016, at 17:27, Alan Somers wrote: > You say it's a 4-disk RAIDZ1. Anything topologically weird, like a > log, cache or spare device? SAS or SATA? Any SAS expanders? Please > open a bug for this and assign to me so we can be sure to get this > fixed in time for 11.0. > > -Alan > > On Mon, Jun 20, 2016 at 8:59 AM, Kristof Provost > wrote: >> Hi, >> >> It looks like this change breaks boot on my machine. >> I’m running a root-on-ZFS system and reliably see this panic during >> boot. >> It’s a 4 disk raidz-1. >> >> It’s now running r302028 with r300881 backed out, and booting fine. >> >> The panic: >> panic: solaris assert: refcount(count(&spa->spa_refcount) >= >> spa->spa_minref >> || >> MUTEX_HELD(&spa_namespace_lock), file: >> /usr/src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/spa_misc.c, >> line: >> 863 >> >> Unfortunately I can’t get a dump, but here’s a picture of the >> backtrace: >> https://people.freebsd.org/~kp/zfs_panic.jpg >> >> Regards, >> Kristof >> >> On 28 May 2016, at 0:32, Alan Somers wrote: >> >> Author: asomers >> Date: Fri May 27 22:32:44 2016 >> New Revision: 300881 >> URL: https://svnweb.freebsd.org/changeset/base/300881 >> >> Log: >> Avoid issuing spa config updates for physical path when not necessary >> >> ZFS's configuration needs to be updated whenever the physical path >> for a >> device changes, but not when a new device is introduced. This is >> because new >> devices necessarily cause config updates, but only if they are >> actually >> accepted into the pool. >> >> sys/cddl/contrib/opensolaris/uts/common/fs/zfs/vdev_geom.c >> Split vdev_geom_set_physpath out of vdev_geom_attrchanged. When >> setting the vdev's physical path, only request a config update if >> the physical path has changed. Don't request it when opening a >> device for the first time, because the config sync will happen >> anyway upstack. >> >> sys/geom/geom_dev.c >> Split g_dev_set_physpath and g_dev_set_media out of >> g_dev_attrchanged >> >> Submitted by: will, asomers >> MFC after: 4 weeks >> Sponsored by: Spectra Logic Corp >> Differential Revision: https://reviews.freebsd.org/D6428 >> >> Modified: >> head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/vdev_geom.c >> head/sys/geom/geom_dev.c