Date: Sun, 01 Dec 2013 17:39:33 +0000 From: Max Brazhnikov <makc@freebsd.org> To: Rusmir Dusko <nemysis@freebsd.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r335345 - head/games/bs Message-ID: <1438162.nG8DGo4IHR@mercury.ph.man.ac.uk> In-Reply-To: <201311302009.rAUK9052093182@svn.freebsd.org> References: <201311302009.rAUK9052093182@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi Rusmir, On Sat, 30 Nov 2013 20:09 +0000Sat Nov 30 20:09:00 2013 Rusmir Dusko wrote: > Author: nemysis > Date: Sat Nov 30 20:09:00 2013 > New Revision: 335345 > URL: http://svnweb.freebsd.org/changeset/ports/335345 > > Log: > - Change maintainer email to @FreeBSD.org > - Change license GPLv2 to BSD > - USES gmake instead of USE_GMAKE > - Add DOCS and Option > - Add Desktop entry file > > Approved by: pawel / wg (mentors, implicit) > > Modified: > head/games/bs/Makefile > > Modified: head/games/bs/Makefile > ============================================================================== > --- head/games/bs/Makefile Sat Nov 30 20:03:06 2013 (r335344) > +++ head/games/bs/Makefile Sat Nov 30 20:09:00 2013 (r335345) > @@ -6,21 +6,32 @@ PORTVERSION= 2.9 > CATEGORIES= games > MASTER_SITES= http://www.catb.org/~esr/bs/ > > -MAINTAINER= nemysis@gmx.ch > +MAINTAINER= nemysis@FreeBSD.org > COMMENT= Battleships solitaire game with a color interface > > -LICENSE= GPLv2 > +LICENSE= BSD > > +USES= gmake > MAKE_ARGS= CC="${CC}" > ALL_TARGET= # empty > -USE_GMAKE= yes > > -MAN6= bs.6 > -PLIST_FILES= bin/bs > +PLIST_FILES= bin/bs \ > + man/man6/bs.6.gz \ > + share/pixmaps/battleship.png > + > +PORTDOCS= NEWS README > + > +OPTIONS_DEFINE= DOCS > + > +DESKTOP_ENTRIES="Battleships" "${COMMENT}" "battleship" \ > + "xterm -e ${PORTNAME}" "Game;ArcadeGame;" false Hardcoding particular terminal in desktop entry does not seem good from users perspective. Although desktop entry specification has a special key for this case (Terminal=true) [*], our DESKTOP_ENTRIES support was designed for simple cases and has no support for it. If you really need desktop entry for this port, probably the best solution would be to use pregenerated desktop file. If there is a substantial demand for terminal applications, we may think about making DESKTOP_ENTRIES more flexible. Btw, if you want to use port's COMMENT for desktop entry, you may leave the corresponding field empty - the ports framework will do the job. If you unsure about StartupNotify field, just leave it empty, rather then forcing 'false'. Cheers, Max [*] http://standards.freedesktop.org/desktop-entry-spec/latest/ar01s05.html
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1438162.nG8DGo4IHR>