From owner-freebsd-current@FreeBSD.ORG  Mon Feb  2 08:30:59 2009
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 19F911065670
	for <freebsd-current@freebsd.org>; Mon,  2 Feb 2009 08:30:57 +0000 (UTC)
	(envelope-from ralph@imada.sdu.dk)
Received: from berlioz.imada.sdu.dk (berlioz.imada.sdu.dk [130.225.128.12])
	by mx1.freebsd.org (Postfix) with ESMTP id 1CD9A8FC1B
	for <freebsd-current@freebsd.org>; Mon,  2 Feb 2009 08:30:56 +0000 (UTC)
	(envelope-from ralph@imada.sdu.dk)
Received: from localhost (localhost [127.0.0.1])
	by localhost.imada.sdu.dk (Postfix) with ESMTP
	id 069836270C; Mon,  2 Feb 2009 09:30:55 +0100 (CET)
X-Virus-Scanned: amavisd-new at imada.sdu.dk
Received: from berlioz.imada.sdu.dk ([127.0.0.1])
	by localhost (berlioz.imada.sdu.dk [127.0.0.1]) (amavisd-new,
	port 10025)
	with ESMTP id AY17PxFRw58Q; Mon,  2 Feb 2009 08:30:52 +0000 (UTC)
Received: from www1.imada.sdu.dk (salieri.imada.sdu.dk [130.225.128.14])
	by berlioz.imada.sdu.dk (Postfix) with SMTP
	id 23AFB62706; Mon,  2 Feb 2009 09:30:52 +0100 (CET)
Received: from 80.160.75.130 (SquirrelMail authenticated user ralph)
	by test.imada.sdu.dk with HTTP; Mon, 2 Feb 2009 09:30:52 +0100 (CET)
Message-ID: <20137.80.160.75.130.1233563452.squirrel@test.imada.sdu.dk>
In-Reply-To: <498607D7.7090507@videotron.ca>
References: <4985FA10.5080604@imada.sdu.dk> <498607D7.7090507@videotron.ca>
Date: Mon, 2 Feb 2009 09:30:52 +0100 (CET)
From: "Ralph Zitz" <ralph@imada.sdu.dk>
To: "Stephane E. Potvin" <sepotvin@videotron.ca>
User-Agent: SquirrelMail/1.4.0
MIME-Version: 1.0
Content-Type: text/plain;charset=iso-8859-1
X-Priority: 3
Importance: Normal
Cc: freebsd-current@freebsd.org
Subject: Re: patch r187693 breaks HAL on amd64-current
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 02 Feb 2009 08:30:59 -0000

Thanks!

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Ralph Zitz wrote:
>> I'm not a HAL expert, but it seems that the patch makes HAL create a
>> zombie process when watching /dev/cd0. Reversing the patch makes HAL
>> work again.
>>
>> Link to patch message:
>> http://lists.freebsd.org/pipermail/svn-src-all/2009-January/004073.html
>>
> Hi Ralph
>
> Try the following patch, it should fix your problem with hal.
>
> Regards
>
> Steph
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v2.0.10 (FreeBSD)
> Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
>
> iEYEARECAAYFAkmGB9YACgkQmdOXtTCX/nt8tACgj5IzDaHDEsKIJbZPefOwzkiW
> Ne4AoMV4GzfMLeVeBAWIRbmG08R7Lpj3
> =K7Cu
> -----END PGP SIGNATURE-----
> Index: kern/sys_generic.c
> ===================================================================
> --- kern/sys_generic.c	(revision 187983)
> +++ kern/sys_generic.c	(working copy)
> @@ -903,7 +903,7 @@
>   * bit position in the fd_mask array.
>   */
>  static __inline int
> -selflags(fd_mask **ibits, int idx, int bit)
> +selflags(fd_mask **ibits, int idx, fd_mask bit)
>  {
>  	int flags;
>  	int msk;
> @@ -912,7 +912,7 @@
>  	for (msk = 0; msk < 3; msk++) {
>  		if (ibits[msk] == NULL)
>  			continue;
> -		if ((ibits[msk][idx] & (fd_mask)bit) == 0)
> +		if ((ibits[msk][idx] & bit) == 0)
>  			continue;
>  		flags |= select_flags[msk];
>  	}
>