From owner-freebsd-hackers@FreeBSD.ORG Thu Aug 28 14:18:08 2014 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 9F157CB3 for ; Thu, 28 Aug 2014 14:18:08 +0000 (UTC) Received: from mail-pa0-x230.google.com (mail-pa0-x230.google.com [IPv6:2607:f8b0:400e:c03::230]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 705851BAD for ; Thu, 28 Aug 2014 14:18:08 +0000 (UTC) Received: by mail-pa0-f48.google.com with SMTP id ey11so2738003pad.7 for ; Thu, 28 Aug 2014 07:18:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=content-type:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=a+upLQxwOK7Vj3d3ouPO/bhBqIg8EA4IQttQdQU/TdQ=; b=mwLfhlv6plx9FYtAs4IQx0KQL0BhaxHK6dlPKQdeQNaUb+jIbi4o3JG8sae9As1Orp ocr9JzkVOiiGN+gqv0Tw2mf90GMnPI6vuQgkrvtGfz6UPXTSM8uz4wq7QDf4ZDXrcOv2 vrd2OKLjXMZAZ7aaxzErFOJbvC/Av0feEoxo+PKHQjr6AL8TbeOGafgFLHDy1dYseMkq LHZIDwb7yaCRg2jJOI2IgpE0OmrmyOVfXs2XwqCJhBd9oafUKjkBBkUcEk+42YslRyxz UxQo8WK+AcqccotJ8llCZTIMJm+nEs6JLSYsYwAxHA5SW1pSJ9GPyrI8m6LcLFcu+O8V dYXw== X-Received: by 10.70.102.5 with SMTP id fk5mr6427820pdb.114.1409235484670; Thu, 28 Aug 2014 07:18:04 -0700 (PDT) Received: from ?IPv6:::1? ([202.55.17.37]) by mx.google.com with ESMTPSA id o2sm5672587pde.30.2014.08.28.07.18.02 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 28 Aug 2014 07:18:04 -0700 (PDT) Content-Type: text/plain; charset="utf8"; Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) Subject: Re: On changing rand(3) to random(3) in awk(1) X-Pgp-Agent: GPGMail (null) From: Chenguang Li In-Reply-To: Date: Thu, 28 Aug 2014 22:17:55 +0800 Content-Transfer-Encoding: 8bit Message-Id: References: <53FEFBB8.5040305@gmail.com> <20140828131526.GA2385@straylight.m.ringlet.net> <5C40F611-22EB-49E4-8925-37922E771C0F@gmail.com> <20140828133846.GB2385@straylight.m.ringlet.net> To: Peter Pentchev X-Mailer: Apple Mail (2.1878.6) Cc: freebsd-hackers@freebsd.org, Vitaly Magerya X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Aug 2014 14:18:08 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 Chenguang Li wrote: > Peter Pentchev wrote: > >>> ... ... >>> [omitted] >> >> Right, but you've hard-coded RANDOM_MAX to 2^32-1. I don't think this >> is correct; I do believe that you should use LONG_MAX for this value. >> Of course, #define RANDOM_MAX LONG_MAX could be fine for this purpose >> here, but the point is to use LONG_MAX instead of 2^32-1. > > I got your point, updated again. :) Wait a minute, isn't LONG_MAX architecture-dependent? It's 9223372036854775807 on my 64-bit FreeBSD box. The range of generated random numbers is explicitly documented. So I am afraid I should hard-code 2^32-1 in the file. Chenguang Li -----BEGIN PGP SIGNATURE----- iQIcBAEBCgAGBQJT/zoTAAoJELG4cS+11lRhycwQALj9YTuHZGW3XVZfq83F+jNu u2mPZP6WarsAwWOUVGKJJEn0+E9TLe72lmIgSVoD+h27Y3lOye3kJ1Hpgx38sXVd Zn554Qi15wbuKDJMUDitJEeBFqlE+9NibVip7UsvzXMAkbGZonJTUAqopz7rXJmY IVZWblq63CUsPa+bz8eQ798jpAB7K+9QAkKaYyllTto0sNBWwCS+ZBO1IV2QzCw6 +BnVlQAioG1Z3cGc4j6lCxED/jGVL0A8dbXa+Eg8x95XfNCJnNDsahwqLBC1P0P7 1pZqJEa4UyLih4QK7msWRqGWXIgnzaytVbLMFEey8pYtc0y3lcHwdvzMgmQ55rvR V9UM68ux2ArcR8OuCKNC/KHPaqzx8RYhmFWj5bwkTylAYrkPbBqb9Ws5L8kBLpLz bn90ofOH+mDzsEyIdoV0C7wFDv0Niu9qubr2qhe2qnSsqQ2lUkIQXIFbSnKfvs1y y3tPB2j1NKVCW6+6S/0oACxOpSAVYuSxzAQqkK/JKvedoJT1/pCmLDTuceAa5Vau E1oCx2pA/8mrB64KNla3dmumSl6cx0bbA0LZb1pByIdlDfqTBaxpKLcBrWchaYnA IN2VVTnJwDv9AXf9BqgwPPRZoTq8JkYwdVT9fS2NniWBnP1l+b/FR5RDBOR6e+MH Ds5aPNGsbbNwGKKSRNWl =m/Rg -----END PGP SIGNATURE-----