From owner-freebsd-ports-bugs@FreeBSD.ORG Thu Apr 27 15:00:31 2006 Return-Path: X-Original-To: freebsd-ports-bugs@hub.freebsd.org Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D027E16A401 for ; Thu, 27 Apr 2006 15:00:31 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 606AF43D4C for ; Thu, 27 Apr 2006 15:00:31 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id k3RF0VfR057084 for ; Thu, 27 Apr 2006 15:00:31 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id k3RF0Vfu057083; Thu, 27 Apr 2006 15:00:31 GMT (envelope-from gnats) Date: Thu, 27 Apr 2006 15:00:31 GMT Message-Id: <200604271500.k3RF0Vfu057083@freefall.freebsd.org> To: freebsd-ports-bugs@FreeBSD.org From: "Andrew Pantyukhin" Cc: Subject: Re: ports/95884: update multimedia/mplayer - libtheora fix X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Andrew Pantyukhin List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Apr 2006 15:00:31 -0000 The following reply was made to PR ports/95884; it has been noted by GNATS. From: "Andrew Pantyukhin" To: "Thomas E. Zander" Cc: bug-followup@freebsd.org Subject: Re: ports/95884: update multimedia/mplayer - libtheora fix Date: Thu, 27 Apr 2006 18:52:11 +0400 On 4/27/06, Thomas E. Zander wrote: > Am Sat, dem 22. Apr 2006, um 11:06 +0400 Uhr schrubte Andrew Pantyukhin > zum Thema [Re: ports/95884: update multimedia/mplayer - libtheora fix]: > > > This tweak doesn't break anything, I don't think it will until > > something like theora 2.0 which is a long wait from now. > > But you really shouldn't do this in your patch: > > -LIB_DEPENDS+=3D theora.1:${PORTSDIR}/multimedia/libtheora > +LIB_DEPENDS+=3D theora:${PORTSDIR}/multimedia/libtheora > > Instead, as your patch bumps theora's major to 2, this one, > > -LIB_DEPENDS+=3D theora.1:${PORTSDIR}/multimedia/libtheora > +LIB_DEPENDS+=3D theora.2:${PORTSDIR}/multimedia/libtheora > > would me much more agreeable. Okay, I'm not experiemced enough to argue and it's your call anyway. This PR (with the above-suggested change) is now dependent on PR #95870