From owner-freebsd-hackers@FreeBSD.ORG  Fri Feb 20 07:25:22 2004
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: freebsd-hackers@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 9D68B16A4CE
	for <hackers@freebsd.org>; Fri, 20 Feb 2004 07:25:22 -0800 (PST)
Received: from tx1.oucs.ox.ac.uk (tx1.oucs.ox.ac.uk [129.67.1.167])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 7554C43D1F
	for <hackers@freebsd.org>; Fri, 20 Feb 2004 07:25:22 -0800 (PST)
	(envelope-from colin.percival@wadham.ox.ac.uk)
Received: from scan1.oucs.ox.ac.uk ([129.67.1.166] helo=localhost)
	by tx1.oucs.ox.ac.uk with esmtp (Exim 4.24)
	id 1AuCWn-00011o-If
	for hackers@freebsd.org; Fri, 20 Feb 2004 15:25:21 +0000
Received: from rx1.oucs.ox.ac.uk ([129.67.1.165])
 by localhost (scan1.oucs.ox.ac.uk [129.67.1.166]) (amavisd-new, port 25)
 with ESMTP id 03675-09 for <hackers@freebsd.org>;
 Fri, 20 Feb 2004 15:25:21 +0000 (GMT)
Received: from gateway.wadham.ox.ac.uk ([163.1.161.253])
	by rx1.oucs.ox.ac.uk with smtp (Exim 4.24)
	id 1AuCWn-00011l-5H
	for hackers@freebsd.org; Fri, 20 Feb 2004 15:25:21 +0000
Received: (qmail 14367 invoked by uid 0); 20 Feb 2004 15:25:21 -0000
Received: from colin.percival@wadham.ox.ac.uk by gateway by uid 71 with
	qmail-scanner-1.16  (sweep: 2.14/3.71. spamassassin: 2.53.  Clear:. 
	Processed in 1.402475 secs); 20 Feb 2004 15:25:21 -0000
X-Qmail-Scanner-Mail-From: colin.percival@wadham.ox.ac.uk via gateway
X-Qmail-Scanner: 1.16 (Clear:. Processed in 1.402475 secs)
Received: from dhcp1131.wadham.ox.ac.uk (HELO piii600.wadham.ox.ac.uk)
	(163.1.161.131)
	by gateway.wadham.ox.ac.uk with SMTP; 20 Feb 2004 15:25:20 -0000
Message-Id: <6.0.1.1.1.20040220152326.038d7cb0@imap.sfu.ca>
X-Sender: cperciva@imap.sfu.ca (Unverified)
X-Mailer: QUALCOMM Windows Eudora Version 6.0.1.1
Date: Fri, 20 Feb 2004 15:25:17 +0000
To: "Ted Unangst" <tedu@coverity.com>
From: Colin Percival <colin.percival@wadham.ox.ac.uk>
In-Reply-To: <19391.66.93.171.98.1077241554.spork@webmail.coverity.com>
References: <19391.66.93.171.98.1077241554.spork@webmail.coverity.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; format=flowed
cc: hackers@freebsd.org
Subject: Re: NULL pointer dereferences
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
	<freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 20 Feb 2004 15:25:22 -0000

At 01:45 20/02/2004, Ted Unangst wrote:
>Some more.  There are bugs where the code checks for NULL after using the
>pointer.  Usually means the check should be earlier, or is unnecessary.

   One false alarm here: uni_msg_pack_mbuf(msg, ...) won't dereference
msg if it is NULL.  Apart from that I've either got patches or sent
emails to the appropriate maintainers.

Colin Percival