From owner-cvs-ports@FreeBSD.ORG  Mon Mar 16 14:37:37 2009
Return-Path: <owner-cvs-ports@FreeBSD.ORG>
Delivered-To: cvs-ports@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 44ABF106564A;
	Mon, 16 Mar 2009 14:37:37 +0000 (UTC)
	(envelope-from amdmi3@amdmi3.ru)
Received: from smtp.timeweb.ru (smtp.timeweb.ru [217.170.79.85])
	by mx1.freebsd.org (Postfix) with ESMTP id F0ECE8FC16;
	Mon, 16 Mar 2009 14:37:36 +0000 (UTC)
	(envelope-from amdmi3@amdmi3.ru)
Received: from [213.148.20.85] (helo=hive.panopticon)
	by smtp.timeweb.ru with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.69)
	(envelope-from <amdmi3@amdmi3.ru>)
	id 1LjDwg-00061C-FD; Mon, 16 Mar 2009 17:37:38 +0300
Received: from hades.panopticon (hades.panopticon [192.168.0.32])
	by hive.panopticon (Postfix) with ESMTP id 4B334F5FD;
	Mon, 16 Mar 2009 17:37:03 +0300 (MSK)
Received: by hades.panopticon (Postfix, from userid 1000)
	id 1D8EE108839; Mon, 16 Mar 2009 17:36:38 +0300 (MSK)
Date: Mon, 16 Mar 2009 17:36:38 +0300
From: Dmitry Marakasov <amdmi3@amdmi3.ru>
To: Oliver Lehmann <lehmann@ans-netz.de>
Message-ID: <20090316143638.GA26242@hades.panopticon>
References: <200903160054.n2G0sdCq010298@repoman.freebsd.org>
	<20090316064227.ef50f937.lehmann@ans-netz.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20090316064227.ef50f937.lehmann@ans-netz.de>
User-Agent: Mutt/1.5.19 (2009-01-05)
Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org
Subject: Re: cvs commit: ports/audio/openal Makefile
X-BeenThere: cvs-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the ports tree <cvs-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-ports>
List-Post: <mailto:cvs-ports@freebsd.org>
List-Help: <mailto:cvs-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 16 Mar 2009 14:37:38 -0000

* Oliver Lehmann (lehmann@ans-netz.de) wrote:

> Will this also fix the following PR? (scroll below for the openal patch)

Seems so. I guess the fix in that PR is even better, as optimized
assembly code is used.

I think we can merge both fixes, something like that:

.if ${ARCH} == "i386"
OPTIONS+=	X86_ASM	"Enable x86 assembly code" on
.endif

...

.if ${ARCH} == "i386" && !defined(WITHOUT_X86_ASM)
BUILD_DEPENDS+=	nasm:${LOCALBASE}/devel/nasm
.endif

...

post-patch:
.if ${ARCH} != "i386" || defined(WITHOUT_X86_ASM)
	@${REINPLACE_CMD} -e '/^NASM=/ s|=.*|=no|' ${WRKSRC}/configure
.endif

and patches from ports/129362.

What do you think?

-- 
Dmitry Marakasov   .   55B5 0596 FF1E 8D84 5F56  9510 D35A 80DD F9D2 F77D
amdmi3@amdmi3.ru  ..:  jabber: amdmi3@jabber.ru    http://www.amdmi3.ru