From owner-svn-src-all@FreeBSD.ORG  Tue Jun  1 19:56:03 2010
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 3951D1065676;
	Tue,  1 Jun 2010 19:56:03 +0000 (UTC) (envelope-from alc@FreeBSD.org)
Received: from svn.freebsd.org (unknown [IPv6:2001:4f8:fff6::2c])
	by mx1.freebsd.org (Postfix) with ESMTP id E0C5D8FC13;
	Tue,  1 Jun 2010 19:56:02 +0000 (UTC)
Received: from svn.freebsd.org (localhost [127.0.0.1])
	by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id o51Ju23W029721;
	Tue, 1 Jun 2010 19:56:02 GMT (envelope-from alc@svn.freebsd.org)
Received: (from alc@localhost)
	by svn.freebsd.org (8.14.3/8.14.3/Submit) id o51Ju2XE029719;
	Tue, 1 Jun 2010 19:56:02 GMT (envelope-from alc@svn.freebsd.org)
Message-Id: <201006011956.o51Ju2XE029719@svn.freebsd.org>
From: Alan Cox <alc@FreeBSD.org>
Date: Tue, 1 Jun 2010 19:56:02 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-all@freebsd.org,
	svn-src-head@freebsd.org
X-SVN-Group: head
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Cc: 
Subject: svn commit: r208720 - head/sys/powerpc/booke
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 01 Jun 2010 19:56:03 -0000

Author: alc
Date: Tue Jun  1 19:56:02 2010
New Revision: 208720
URL: http://svn.freebsd.org/changeset/base/208720

Log:
  In the case that mmu_booke_enter_locked() is changing the attributes of a
  mapping but not changing the physical page being mapped, the wrong flags
  were being inspected in order to determine whether or not to flush the
  instruction cache.  The effect of looking at the wrong flags was that the
  instruction cache was never being flushed.
  
  Reviewed by:	marcel

Modified:
  head/sys/powerpc/booke/pmap.c

Modified: head/sys/powerpc/booke/pmap.c
==============================================================================
--- head/sys/powerpc/booke/pmap.c	Tue Jun  1 19:39:27 2010	(r208719)
+++ head/sys/powerpc/booke/pmap.c	Tue Jun  1 19:56:02 2010	(r208720)
@@ -1621,7 +1621,7 @@ mmu_booke_enter_locked(mmu_t mmu, pmap_t
 			 * are turning execute permissions on, icache should
 			 * be flushed.
 			 */
-			if ((flags & (PTE_UX | PTE_SX)) == 0)
+			if ((pte->flags & (PTE_UX | PTE_SX)) == 0)
 				sync++;
 		}