From owner-svn-src-user@FreeBSD.ORG Sat Nov 8 02:02:13 2008 Return-Path: Delivered-To: svn-src-user@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6E7B21065670; Sat, 8 Nov 2008 02:02:13 +0000 (UTC) (envelope-from kmacy@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id 5E1DD8FC16; Sat, 8 Nov 2008 02:02:13 +0000 (UTC) (envelope-from kmacy@FreeBSD.org) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id mA822DGR098284; Sat, 8 Nov 2008 02:02:13 GMT (envelope-from kmacy@svn.freebsd.org) Received: (from kmacy@localhost) by svn.freebsd.org (8.14.3/8.14.3/Submit) id mA822D0W098283; Sat, 8 Nov 2008 02:02:13 GMT (envelope-from kmacy@svn.freebsd.org) Message-Id: <200811080202.mA822D0W098283@svn.freebsd.org> From: Kip Macy Date: Sat, 8 Nov 2008 02:02:13 +0000 (UTC) To: src-committers@freebsd.org, svn-src-user@freebsd.org X-SVN-Group: user MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r184759 - user/kmacy/HEAD_fast_multi_xmit/sys/net X-BeenThere: svn-src-user@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the experimental " user" src tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 08 Nov 2008 02:02:13 -0000 Author: kmacy Date: Sat Nov 8 02:02:13 2008 New Revision: 184759 URL: http://svn.freebsd.org/changeset/base/184759 Log: add memory barrier before critical_exit to ensure that all buffered updates are committed to main memory before a preemption is permitted Modified: user/kmacy/HEAD_fast_multi_xmit/sys/net/flowtable.c Modified: user/kmacy/HEAD_fast_multi_xmit/sys/net/flowtable.c ============================================================================== --- user/kmacy/HEAD_fast_multi_xmit/sys/net/flowtable.c Fri Nov 7 23:50:57 2008 (r184758) +++ user/kmacy/HEAD_fast_multi_xmit/sys/net/flowtable.c Sat Nov 8 02:02:13 2008 (r184759) @@ -35,6 +35,21 @@ #define calloc(count, size) malloc((count)*(size), M_DEVBUF, M_WAITOK|M_ZERO) + +#if defined (__GNUC__) + #if #cpu(i386) || defined __i386 || defined i386 || defined __i386__ || #cpu(x86_64) || defined __x86_64__ + #define mb() __asm__ __volatile__ ("sfence;": : :"memory") + #elif #cpu(sparc64) || defined sparc64 || defined __sparcv9 + #define mb() __asm__ __volatile__ ("membar #MemIssue": : :"memory") + #elif #cpu(sparc) || defined sparc || defined __sparc__ + #define mb() __asm__ __volatile__ ("stbar;": : :"memory") + #else + #define mb() /* XXX just to make this compile */ + #endif +#else + #error "unknown compiler" +#endif + /* * Taken from http://burtleburtle.net/bob/c/lookup3.c */ @@ -317,6 +332,7 @@ static void flowtable_pcpu_unlock(struct flowtable *table, uint32_t hash) { + mb(); critical_exit(); }