From owner-freebsd-hackers@FreeBSD.ORG Fri Oct 26 19:17:14 2012 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 53F7051D; Fri, 26 Oct 2012 19:17:14 +0000 (UTC) (envelope-from yanegomi@gmail.com) Received: from mail-oa0-f54.google.com (mail-oa0-f54.google.com [209.85.219.54]) by mx1.freebsd.org (Postfix) with ESMTP id E54F08FC08; Fri, 26 Oct 2012 19:17:13 +0000 (UTC) Received: by mail-oa0-f54.google.com with SMTP id n9so3865179oag.13 for ; Fri, 26 Oct 2012 12:17:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; bh=kKZQyLY8fcEGDtEsgWT9kbyL/rDN04+N91QmZ1BZT7Q=; b=WA6DTfE7HArf0wJlRhkqNHXO8nw2aww5i08XrFtcFMPeq/eGK0hFXvllVyBS8sbgXD nKNGC9Py3SveNTCp0AK8IO39cWtGoRgHGFWsIORvgSwUplOsw3oaw+22G7/Js409DpkR YgSJttR6GaR8w2v+nvY6C8UgCiByhSdTtqb8t/VpmOPM4xjShDbaQK8yJH0p3djUWpS9 1Iy5+URAz3kK6YXwyR4JQ9Otdja7+12Y29eMHn0O6m37ZF2dxLML77NpgBwDg6WRKbwS 1kMzJnTsTSEWow8Ar6GfID4LI6lMq9s45H997QTERY408qzVEH6ycmpuk0bvh0Dvj4Ef fd5w== MIME-Version: 1.0 Received: by 10.182.131.100 with SMTP id ol4mr19210246obb.38.1351279033332; Fri, 26 Oct 2012 12:17:13 -0700 (PDT) Received: by 10.76.143.33 with HTTP; Fri, 26 Oct 2012 12:17:13 -0700 (PDT) In-Reply-To: <20121026163420.GE43045@dragon.NUXI.org> References: <20121026163420.GE43045@dragon.NUXI.org> Date: Fri, 26 Oct 2012 12:17:13 -0700 Message-ID: Subject: Re: Installing make as pmake when WITH_BMAKE specified (was Re: [CFT/RFC]: refactor bsd.prog.mk to understand multiple programs instead of a singular program) From: Garrett Cooper To: obrien@freebsd.org, Garrett Cooper , Marcel Moolenaar , freebsd-hackers@freebsd.org, freebsd-arch@freebsd.org, "Simon J. Gerraty" Content-Type: text/plain; charset=ISO-8859-1 X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Oct 2012 19:17:14 -0000 On Fri, Oct 26, 2012 at 9:34 AM, David O'Brien wrote: > On Thu, Oct 25, 2012 at 03:00:21PM -0700, Garrett Cooper wrote: >> Here's an updated version of the workaround that works properly in all >> cases and installs bmake as make and links make to pmake when >> WITH_BMAKE=yes, and installs make as make when WITHOUT_BMAKE is >> specified (this works better than the previous patch I sent to Simon). > > Garrett, > I don't see how this could be committed -- it will make it difficult > for 10-CURRENT folks to build ports (and there are no pre-build packages > for 10-CURRENT). I don't want it committed because Simon's move makes sense longterm: I wanted to offer an alternative as opposed to just being stuck in purgatory and figured that others might benefit from it. We're stuck at a point now that we need to make a break but we also need to ensure that we don't break things too badly for users with older versions of make. Installing our version of make as something other than `make` would at least allow us to use make as pmake in ports, but I realized it would requiring hacking around portmaster, portupgrade, and a number of other tools that expect FreeBSD make to be make and don't have a means of parameterizing make in the environment or on the command line. So looking back now my mitigation solution would not be ideal and would not fix any problems really. > Are you not able to use this instead (w/"WANT_USRBIN_BMAKE=" in /etc/src.conf)? That would be interesting too (and is a lot less involved than my patch), and probably would have less fallout. Thanks! -Garrett