From owner-freebsd-ports@FreeBSD.ORG Wed Apr 14 07:17:06 2010 Return-Path: Delivered-To: ports@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A44B7106566B; Wed, 14 Apr 2010 07:17:06 +0000 (UTC) (envelope-from avg@icyb.net.ua) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id AE01C8FC1D; Wed, 14 Apr 2010 07:17:05 +0000 (UTC) Received: from porto.topspin.kiev.ua (porto-e.starpoint.kiev.ua [212.40.38.100]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id KAA18165; Wed, 14 Apr 2010 10:17:00 +0300 (EEST) (envelope-from avg@icyb.net.ua) Received: from localhost.topspin.kiev.ua ([127.0.0.1]) by porto.topspin.kiev.ua with esmtp (Exim 4.34 (FreeBSD)) id 1O1wqJ-0000ER-OY; Wed, 14 Apr 2010 10:16:59 +0300 Message-ID: <4BC56BEA.6020904@icyb.net.ua> Date: Wed, 14 Apr 2010 10:16:58 +0300 From: Andriy Gapon User-Agent: Thunderbird 2.0.0.24 (X11/20100321) MIME-Version: 1.0 To: Maho NAKATA References: <4BBDC3E1.3070304@icyb.net.ua> <20100408093444.2c4acfa9@locust.local> <4BBDF7D1.6070709@icyb.net.ua> <20100414.074742.519459540419532564.chat95@mac.com> In-Reply-To: <20100414.074742.519459540419532564.chat95@mac.com> X-Enigmail-Version: 0.96.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: ports@FreeBSD.org, srandall52@gmail.com, openoffice@FreeBSD.org Subject: Re: openoffice.org-3.2.0-spadmin X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Apr 2010 07:17:06 -0000 on 14/04/2010 01:47 Maho NAKATA said the following: > Andriy are you a committer? Different kind - an src one :-) > If you are, you can submit patch to me and I'll approve. > thanks! The patch: --- Makefile.orig 2010-04-14 10:13:44.064102203 +0300 +++ Makefile 2010-04-14 10:15:11.615310335 +0300 @@ -251,6 +251,7 @@ @${REINPLACE_CMD} -e 's#%%PREFIX%%#${PREFIX}#g' \ -e 's#%%OOOTAG%%#${OOOTAG}#g' \ -e 's#%%OOODIR%%#${OOODIR}#g' \ + -e 's#%%OOOVERSION%%#${OOOVERSION}#g' \ -e 's#%%INSTALLATION_BASEDIR%%#${INSTALLATION_BASEDIR}#g' \ ${WRKDIR}/openoffice.org-wrapper @${INSTALL_SCRIPT} ${WRKDIR}/openoffice.org-wrapper \ P.S. sorry for not recognizing you, our openoffice.org maintainer, in the other thread on stable@ :-) > From: Andriy Gapon > Subject: Re: openoffice.org-3.2.0-spadmin > Date: Thu, 08 Apr 2010 18:35:45 +0300 > >> on 08/04/2010 17:34 Steve Randall said the following: >>> On Thu, 08 Apr 2010 14:54:09 +0300 >>> Andriy Gapon wrote: >>> >>>> Not sure if this is an upstream issue or something in editors/openoffice.org-3: >>>> openoffice.org-3.2.0-spadmin is a symlink to openoffice.org-3.2.0 and running it >>>> produces a "new document" startup window. >>>> I believe that it should be a symlink to >>>> ${LOCALBASE}/openoffice.org-3.2.0/openoffice.org3/program/spadmin which is the >>>> actual openoffice.org printer configuration program which, for example, allows to >>>> select which of the printers is to be used as a default one. >>> There's an omission in the port Makefile. The problem is that the >>> wrapper script /usr/local/bin/openoffice.org-3.2.0 contains a >>> %%OOOVERSION%% that does not get replaced (with "3.2.0") prior to >>> installing the file. Just make that change manually and it will work. >> Oh, I see what you say: >> ... >> oopath=/usr/local/openoffice.org-3.2.0/openoffice.org3 >> program=`echo $0 | sed -e 's|.*-%%OOOVERSION%%-||'` >> ... >> >> Probably replace command for openoffice.org-wrapper file in post-install target >> needs to grow the following substitution: >> -e 's#%%OOOVERSION%%#${OOOVERSION}#g' >> >> -- >> Andriy Gapon >> _______________________________________________ >> freebsd-openoffice@freebsd.org mailing list >> http://lists.freebsd.org/mailman/listinfo/freebsd-openoffice >> To unsubscribe, send any mail to "freebsd-openoffice-unsubscribe@freebsd.org" >> -- Andriy Gapon