From owner-p4-projects@FreeBSD.ORG  Mon Apr 21 18:24:04 2008
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 9CBF910656B0; Mon, 21 Apr 2008 18:24:04 +0000 (UTC)
Delivered-To: perforce@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 5E1431065689
	for <perforce@FreeBSD.org>; Mon, 21 Apr 2008 18:24:04 +0000 (UTC)
	(envelope-from hselasky@FreeBSD.org)
Received: from repoman.freebsd.org (repoman.freebsd.org
	[IPv6:2001:4f8:fff6::29])
	by mx1.freebsd.org (Postfix) with ESMTP id 53C048FC3F
	for <perforce@FreeBSD.org>; Mon, 21 Apr 2008 18:24:04 +0000 (UTC)
	(envelope-from hselasky@FreeBSD.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id m3LIO3uc031819
	for <perforce@FreeBSD.org>; Mon, 21 Apr 2008 18:24:03 GMT
	(envelope-from hselasky@FreeBSD.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.14.1/8.14.1/Submit) id m3LIO3Nf031817
	for perforce@freebsd.org; Mon, 21 Apr 2008 18:24:03 GMT
	(envelope-from hselasky@FreeBSD.org)
Date: Mon, 21 Apr 2008 18:24:03 GMT
Message-Id: <200804211824.m3LIO3Nf031817@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	hselasky@FreeBSD.org using -f
From: Hans Petter Selasky <hselasky@FreeBSD.org>
To: Perforce Change Reviews <perforce@FreeBSD.org>
Cc: 
Subject: PERFORCE change 140367 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 21 Apr 2008 18:24:05 -0000

http://perforce.freebsd.org/chv.cgi?CH=140367

Change 140367 by hselasky@hselasky_laptop001 on 2008/04/21 18:23:48

	
	Need to flush after last write to structure and not before.

Affected files ...

.. //depot/projects/usb/src/sys/dev/usb/ehci.c#76 edit
.. //depot/projects/usb/src/sys/dev/usb/ohci.c#63 edit
.. //depot/projects/usb/src/sys/dev/usb/uhci.c#62 edit

Differences ...

==== //depot/projects/usb/src/sys/dev/usb/ehci.c#76 (text+ko) ====

@@ -1113,11 +1113,11 @@
 
 		sqh->qh_qtd.qtd_next = htole32(EHCI_LINK_TERMINATE);
 
-		usbd_pc_cpu_flush(sqh->page_cache);
-
 		last = ((last == sqh) ? sqh->prev : last);
 
 		sqh->prev = 0;
+
+		usbd_pc_cpu_flush(sqh->page_cache);
 	}
 	return (last);
 }

==== //depot/projects/usb/src/sys/dev/usb/ohci.c#63 (text+ko) ====

@@ -755,11 +755,11 @@
 		sed->ed_flags |= htole32(OHCI_ED_SKIP);
 		sed->ed_headp = sed->ed_tailp;
 
-		usbd_pc_cpu_flush(sed->page_cache);
-
 		last = ((last == sed) ? sed->prev : last);
 
 		sed->prev = 0;
+
+		usbd_pc_cpu_flush(sed->page_cache);
 	}
 	return (last);
 }

==== //depot/projects/usb/src/sys/dev/usb/uhci.c#62 (text+ko) ====

@@ -1011,11 +1011,11 @@
 		 */
 		sqh->qh_e_next = htole32(UHCI_PTR_T);
 
-		usbd_pc_cpu_flush(sqh->page_cache);
-
 		last = ((last == sqh) ? sqh->h_prev : last);
 
 		sqh->h_prev = 0;
+
+		usbd_pc_cpu_flush(sqh->page_cache);
 	}
 	return (last);
 }