From nobody Tue Sep 2 20:10:20 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cGcL952x1z65LpZ; Tue, 02 Sep 2025 20:10:25 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cGcL90rpwz3r9J; Tue, 02 Sep 2025 20:10:25 +0000 (UTC) (envelope-from kp@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1756843825; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=PyH++rPa/wFS0XmMZwjROOtWqwFR+aWk82iaowKUfL0=; b=E2tAa9sCynVBpiFMaItVHnI26H3vEyr0nlRnmuQKQSs9kNZtBS8/PQsYASL4pKTvhgyJpV sEdT9/Sh+qjvwJSjWfTpzRbIbRfoN5Hi9YTF6Q/XuR1Vcq5yfETBqzMAfuO1/7cRZ4gbdf zUEo6Kf+m75bNM6hlyomU8PJ+sPhJGWJZ1htisGEAjeEPcsA5DQTlexRGwXmbdCF8IfzLx bZACAA7g6eP8/XEEgSsboApHX4dDLJbOWKvwvPhfY69/0YErudBw9KZM7eOnRtT3CxwHNF QIv0cDDOQBnGBr+RKbeyrNRnWmRoZQcYM8cOgvQThV/XtfmkhhVvCpH3upvx5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1756843825; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=PyH++rPa/wFS0XmMZwjROOtWqwFR+aWk82iaowKUfL0=; b=qX+SgnT8HP8U6YYDbB+1kBN0oRIjQ6ZVGi/RTOVNh4nqCGn8p5t0acr0uhQxSYihsr13Oj egxlQF08V9YkBpEtpL3n/4yLeLyJ66CYOOs1ugGTH7Ct/ZYwjbxrpFEaXS3lcd9RyI97Bb CoiEur+ESG5MoPpIYTpbqv/x7zDPz4JaSRz+JSj17NKxPlf398bMiV8CmIqOJXnb+vkTne zb6YCjdlprRX7K509RoZOO6/4Kc3VxwMjXHtCdfpW1pddkvytzyOLrxCIehKUgvtFgBkgx rujkbGz2Vbd8c1Ypm3ekXuul8gh5EfUqK2Hqy6mt0/qU1G26sdrrPkSFGuAU0A== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1756843825; a=rsa-sha256; cv=none; b=CA/61ODsLKgE0JKGjbVMR5/s4xR+ifb18GLMXb6lp9wtDDXwafwMUhRyH1XEQk2ZUBA/5y JrsKItFvMHKqoOIMj00XRT675Nr/Ahx+70fWG5lfV0j+F556n50bBL1fy88YB9h2ZUoF7l 4eKOMclK0bKtcRzuiBtEqlXFP83Qcoy9fV3kEAKHO0L5kpvw11pW5oHZ/7LrH90T0tPUix 1sb1ph0T8Hr365A+KTynXlWl4dNIfhTwf/LvbwWmOz904oTGdZoAZtslgI4JUAHkEcMMo5 PYvZURJcS+BkXIzefqb97d+MdThikZtGjJx1uowLhGXQlXsyNrRCLHjhhKPX2A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from venus.codepro.be (venus.codepro.be [5.9.86.228]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mx1.codepro.be", Issuer "R11" (verified OK)) (Authenticated sender: kp) by smtp.freebsd.org (Postfix) with ESMTPSA id 4cGcL85dMLzmvs; Tue, 02 Sep 2025 20:10:24 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: by venus.codepro.be (Postfix, authenticated sender kp) id D67F5441CA; Tue, 02 Sep 2025 22:10:21 +0200 (CEST) From: Kristof Provost To: Michael Tuexen Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: e4ea162509e4 - main - epair: add support for checksum offloading Date: Tue, 02 Sep 2025 22:10:20 +0200 X-Mailer: MailMate (2.0r6272) Message-ID: <1781EA53-EA6F-456B-B69D-74243A13F3FC@FreeBSD.org> In-Reply-To: <202509012217.581MHwPo033928@gitrepo.freebsd.org> References: <202509012217.581MHwPo033928@gitrepo.freebsd.org> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="=_MailMate_446E6C3D-1156-441E-B79E-33CF62376E4D_=" --=_MailMate_446E6C3D-1156-441E-B79E-33CF62376E4D_= Content-Type: text/plain; charset=UTF-8; format=flowed; markup=markdown Content-Transfer-Encoding: quoted-printable On 2 Sep 2025, at 0:17, Michael Tuexen wrote: > The branch main has been updated by tuexen: > > URL: = > https://cgit.FreeBSD.org/src/commit/?id=3De4ea162509e400340a2bc3e755071= a92f3465e2d > > commit e4ea162509e400340a2bc3e755071a92f3465e2d > Author: Timo V=C3=B6lker > AuthorDate: 2025-09-01 22:03:47 +0000 > Commit: Michael Tuexen > CommitDate: 2025-09-01 22:15:51 +0000 > > epair: add support for checksum offloading > > Add capabilities RXCSUM and RXCSUM6 as well as TXCSUM and TXCSUM6 = > for > for receive and transmit checksum offloading for TCP and UDP to = > the > epair interface and enable them by default. > RXCSUM and RXCSUM6 are enabled because an epair interface may = > receive > a packet with the csum_flag CSUM_DATA_VALID set, which is expected > only if these capabilities are enabled. Since it seems not helpful = > to > remove this flag, it is not possible to disable these = > capabilities. > TXCSUM and TXCSUM6 are synchronized between the two epair = > interface > ends. If enabled/disabled on one end, it will be enabled/disabled = > on > the other end. If the sending epair interface end has TXCSUM or = > TXCSUM6 > enabled and the receiving end is in a bridge, it is assumed that = > all > interfaces in the bridge have that capability enabled. Otherwise = > the > bridge would have disabled that capability on the receiving epair > interface end in the bridge which would have disabled that = > capability > on the sending epair interface end as well due to the = > synchronization. > > Reviewed by: bcr, Seyed Pouria Mousavizadeh Tehrani > MFC after: 4 weeks > Differential Revision: https://reviews.freebsd.org/D51639 This seems to be causing a lot of pf test failures, especially in the = route_to tests. All of these now fail, unless this commit is reverted: nat:binat_compat -> failed: atf-check failed; see the output of the = test for details [4.423s] nat:binat_match -> failed: atf-check failed; see the output of the = test for details [7.535s] nat:nat_match -> failed: atf-check failed; see the output of the test = for details [4.511s] nat:nat_pass -> failed: atf-check failed; see the output of the test = for details [7.337s] nat64:tcp_in_floating -> failed: Failed to connect to TCP server = [6.142s] nat64:tcp_in_if_bound -> failed: Failed to connect to TCP server = [6.048s] nat64:tcp_out_floating -> failed: Failed to connect to TCP server = [6.268s] nat64:tcp_out_if_bound -> failed: Failed to connect to TCP server = [6.253s] nat64:udp_in -> failed: Failed to connect to UDP server [6.097s] nat64:udp_out -> failed: Failed to connect to UDP server [6.071s] rdr:tcp_v6_compat -> failed: 0 !=3D 22 ( 0 !=3D 22) = [2.736s] rdr:tcp_v6_pass -> failed: 0 !=3D 23 ( 0 !=3D 23) [1.97= 8s] route_to:prefer_ipv6_nexthop_ipv4_random_prefix_ipv4 -> failed: = atf-check failed; see the output of the test for details [5.693s] route_to:prefer_ipv6_nexthop_ipv4_random_table_ipv4 -> failed: = atf-check failed; see the output of the test for details [12.511s] route_to:prefer_ipv6_nexthop_ipv6_random_prefix_ipv4 -> failed: = atf-check failed; see the output of the test for details [14.865s] route_to:prefer_ipv6_nexthop_ipv6_random_prefix_ipv6 -> failed: = atf-check failed; see the output of the test for details [7.849s] route_to:prefer_ipv6_nexthop_mixed_af_random_table_ipv4 -> failed: = atf-check failed; see the output of the test for details [11.843s] route_to:prefer_ipv6_nexthop_mixed_af_roundrobin_ipv4 -> failed: = atf-check failed; see the output of the test for details [5.566s] route_to:prefer_ipv6_nexthop_mixed_af_roundrobin_ipv6 -> failed: = atf-check failed; see the output of the test for details [11.089s] route_to:prefer_ipv6_nexthop_single_ipv4 -> failed: atf-check failed; = see the output of the test for details [6.615s] route_to:prefer_ipv6_nexthop_single_ipv6 -> failed: atf-check failed; = see the output of the test for details [7.210s] route_to:random_prefix -> failed: atf-check failed; see the output of = the test for details [6.608s] route_to:random_table -> failed: atf-check failed; see the output of = the test for details [6.513s] route_to:roundrobin -> failed: atf-check failed; see the output of = the test for details [6.248s] route_to:table_loop -> failed: atf-check failed; see the output of = the test for details [6.606s] src_track:max_src_conn_rule -> failed: atf-check failed; see the = output of the test for details [4.743s] src_track:max_src_states_global -> failed: atf-check failed; see the = output of the test for details [5.010s] src_track:max_src_states_rule -> failed: atf-check failed; see the = output of the test for details [5.026s] src_track:mixed_af -> failed: atf-check failed; see the output of the = test for details [5.532s] Best regards, Kristof --=_MailMate_446E6C3D-1156-441E-B79E-33CF62376E4D_= Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

On 2 Sep 2025, at 0:17, Michael Tuexen wrote:

The branch main has been updated by tuexen:

URL: https://cgit.FreeBSD.org/src/co= mmit/?id=3De4ea162509e400340a2bc3e755071a92f3465e2d

commit e4ea162509e400340a2bc3e755071a92f3465e2d
Author: Timo V=C3=B6lker timo.voelker@fh-muenster.de
AuthorDate: 2025-09-01 22:03:47 +0000
Commit: Michael Tuexen tuexen@F= reeBSD.org
CommitDate: 2025-09-01 22:15:51 +0000

ep=
air: add support for checksum offloading

Add capabilities RXCSUM and RXCSUM6 as well as TXCSUM and TXCSUM6 for
for receive and transmit checksum offloading for TCP and UDP to the
epair interface and enable them by default.
RXCSUM and RXCSUM6 are enabled because an epair interface may receive
a packet with the csum_flag CSUM_DATA_VALID set, which is expected
only if these capabilities are enabled. Since it seems not helpful to
remove this flag, it is not possible to disable these capabilities.
TXCSUM and TXCSUM6 are synchronized between the two epair interface
ends. If enabled/disabled on one end, it will be enabled/disabled on
the other end. If the sending epair interface end has TXCSUM or TXCSUM6
enabled and the receiving end is in a bridge, it is assumed that all
interfaces in the bridge have that capability enabled. Otherwise the
bridge would have disabled that capability on the receiving epair
interface end in the bridge which would have disabled that capability
on the sending epair interface end as well due to the synchronization.

Reviewed by:            bcr, Seyed Pouria Mousavizadeh Tehrani
MFC after:              4 weeks
Differential Revision:  https://reviews.freebsd.org/D51639

This seems to be causing a lot of pf test failures, espec= ially in the route_to tests.

All of these now fail, unless this commit is reverted: 

na=
t:binat_compat  ->  failed: atf-check failed; see the output of the te=
st for details  [4.423s]
nat:binat_match  ->  failed: atf-check failed; see the output of the t=
est for details  [7.535s]
nat:nat_match  ->  failed: atf-check failed; see the output of the tes=
t for details  [4.511s]
nat:nat_pass  ->  failed: atf-check failed; see the output of the test=
 for details  [7.337s]
nat64:tcp_in_floating  ->  failed: Failed to connect to TCP server  [6=
=2E142s]
nat64:tcp_in_if_bound  ->  failed: Failed to connect to TCP server  [6=
=2E048s]
nat64:tcp_out_floating  ->  failed: Failed to connect to TCP server  [=
6.268s]
nat64:tcp_out_if_bound  ->  failed: Failed to connect to TCP server  [=
6.253s]
nat64:udp_in  ->  failed: Failed to connect to UDP server  [6.097s]
nat64:udp_out  ->  failed: Failed to connect to UDP server  [6.071s]
rdr:tcp_v6_compat  ->  failed:        0 !=3D       22 ( 0 !=3D  22)  [=
2.736s]
rdr:tcp_v6_pass  ->  failed:        0 !=3D       23 ( 0 !=3D  23)  [1.=
978s]
route_to:prefer_ipv6_nexthop_ipv4_random_prefix_ipv4  ->  failed: atf-=
check failed; see the output of the test for details  [5.693s]
route_to:prefer_ipv6_nexthop_ipv4_random_table_ipv4  ->  failed: atf-c=
heck failed; see the output of the test for details  [12.511s]
route_to:prefer_ipv6_nexthop_ipv6_random_prefix_ipv4  ->  failed: atf-=
check failed; see the output of the test for details  [14.865s]
route_to:prefer_ipv6_nexthop_ipv6_random_prefix_ipv6  ->  failed: atf-=
check failed; see the output of the test for details  [7.849s]
route_to:prefer_ipv6_nexthop_mixed_af_random_table_ipv4  ->  failed: a=
tf-check failed; see the output of the test for details  [11.843s]
route_to:prefer_ipv6_nexthop_mixed_af_roundrobin_ipv4  ->  failed: atf=
-check failed; see the output of the test for details  [5.566s]
route_to:prefer_ipv6_nexthop_mixed_af_roundrobin_ipv6  ->  failed: atf=
-check failed; see the output of the test for details  [11.089s]
route_to:prefer_ipv6_nexthop_single_ipv4  ->  failed: atf-check failed=
; see the output of the test for details  [6.615s]
route_to:prefer_ipv6_nexthop_single_ipv6  ->  failed: atf-check failed=
; see the output of the test for details  [7.210s]
route_to:random_prefix  ->  failed: atf-check failed; see the output o=
f the test for details  [6.608s]
route_to:random_table  ->  failed: atf-check failed; see the output of=
 the test for details  [6.513s]
route_to:roundrobin  ->  failed: atf-check failed; see the output of t=
he test for details  [6.248s]
route_to:table_loop  ->  failed: atf-check failed; see the output of t=
he test for details  [6.606s]
src_track:max_src_conn_rule  ->  failed: atf-check failed; see the out=
put of the test for details  [4.743s]
src_track:max_src_states_global  ->  failed: atf-check failed; see the=
 output of the test for details  [5.010s]
src_track:max_src_states_rule  ->  failed: atf-check failed; see the o=
utput of the test for details  [5.026s]
src_track:mixed_af  ->  failed: atf-check failed; see the output of th=
e test for details  [5.532s]

Best regards,
Kristof

--=_MailMate_446E6C3D-1156-441E-B79E-33CF62376E4D_=--