From owner-freebsd-multimedia@FreeBSD.ORG  Wed Aug 13 13:19:49 2008
Return-Path: <owner-freebsd-multimedia@FreeBSD.ORG>
Delivered-To: freebsd-multimedia@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 38BBA1065672;
	Wed, 13 Aug 2008 13:19:49 +0000 (UTC) (envelope-from mav@FreeBSD.org)
Received: from cmail.optima.ua (cmail.optima.ua [195.248.191.121])
	by mx1.freebsd.org (Postfix) with ESMTP id 7BC168FC1F;
	Wed, 13 Aug 2008 13:19:48 +0000 (UTC) (envelope-from mav@FreeBSD.org)
X-Spam-Flag: SKIP
X-Spam-Yversion: Spamooborona-2.1.0
Received: from [212.86.226.226] (account mav@alkar.net HELO
	mavbook.mavhome.dp.ua)
	by cmail.optima.ua (CommuniGate Pro SMTP 5.1.14)
	with ESMTPSA id 193704718; Wed, 13 Aug 2008 16:19:47 +0300
Message-ID: <48A2DF6A.4090807@FreeBSD.org>
Date: Wed, 13 Aug 2008 16:19:38 +0300
From: Alexander Motin <mav@FreeBSD.org>
User-Agent: Thunderbird 2.0.0.16 (X11/20080726)
MIME-Version: 1.0
To: Alexander Leidinger <Alexander@Leidinger.net>
References: <48A20E02.6070609@FreeBSD.org>
	<20080813144323.191755ysxy2w38so@webmail.leidinger.net>
In-Reply-To: <20080813144323.191755ysxy2w38so@webmail.leidinger.net>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: freebsd-multimedia@FreeBSD.org, ariff@FreeBSD.org
Subject: Re: RFC: massive snd_hda driver update to better conform
	UAA	specification
X-BeenThere: freebsd-multimedia@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Multimedia discussions <freebsd-multimedia.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-multimedia>, 
	<mailto:freebsd-multimedia-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-multimedia>
List-Post: <mailto:freebsd-multimedia@freebsd.org>
List-Help: <mailto:freebsd-multimedia-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-multimedia>, 
	<mailto:freebsd-multimedia-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 13 Aug 2008 13:19:49 -0000

Alexander Leidinger wrote:
>> I have made major snd_hda driver rewrite. I will be grateful for 
>> reviews and any positive or negative feedbacks.
> 
> Have you already asked Ariff for a review? I've CCed him...

I have written to him several times but with no reply.

>> Here is my patches: http://people.freebsd.org/~mav/
>>
>> For 8-CURRENT use:
>> http://people.freebsd.org/~mav/hda.20080812.patch
> 
> I can not do a technical about this stuff, but I noticed that you use 
> comments to disable code. Please use "#if 0" instead of comments to 
> disable code.

It's temporal. Mostly it's code parts which I haven't yet decided needed 
they or not. I will cleanup this in final version. Now it is just a 
first preview made to collect some initial feedbacks about codecs and 
setups I am unable to test myself.

-- 
Alexander Motin