From owner-dev-commits-src-all@freebsd.org Sun Feb 28 02:39:38 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 9D28B55DAE2 for ; Sun, 28 Feb 2021 02:39:38 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qv1-xf34.google.com (mail-qv1-xf34.google.com [IPv6:2607:f8b0:4864:20::f34]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Dp6zt3Qc3z4kZq for ; Sun, 28 Feb 2021 02:39:38 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qv1-xf34.google.com with SMTP id k7so3876916qvo.6 for ; Sat, 27 Feb 2021 18:39:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=SZQtdZDkNGyYqENqZH+j0EVHFbfcTFfbcZMQXuAKhvw=; b=NwE1zbikGeFZ3I4RWirhnjsJtsMxMj13OsIXPyBn1ckQP79A9NX/4wgnNMcuVHgSUK 6qUt/Wyk1p5uWAv7eZOp1UVaW7HkGezglckWuFb+y23hqP5oKj5nXz07Iit0df/CL3tz zVYxCTpzJiuEMq3UN5ruZacusxGY/OCAPrjEZMNHyqnFusk/TZw3EDjaoF6JnGHPDull JD7jN8agonrBWFEr9FDyJtulzmkF2rcJhVtHeh8yU4THsfr07ysaQJSHgHND0Cl+xgdX ZCpdA3Yf+zf5Y/ZMGSbTUP+obhwsa1Ov56U0hQfc9p9hzI95g0krPFFT6ymuoekLwYdH abAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=SZQtdZDkNGyYqENqZH+j0EVHFbfcTFfbcZMQXuAKhvw=; b=YnbFB0daFVAgxudl9z4gzH5QOR+Pa+j0QeDjEE7BSOScHxADoN/FJ8JzbN3s4Lyh7l SRfMKwMggn3Pl2GBlurllM6YrHTMzMI0IMMN8+PVmGZ0DqcvspQfAsnCWASfEuptvlMP 6VmsBOhpm7imsPoa944FnceALfr3It2o55DE0SSWB/DN8Yst/ipRr1tJEJwO1O1/64S6 0jt8x+k6pfrttO2LSAVpdK0wuwrvHq7CxBZBF/fH1lvnk1zoBkA4C+nJ+ne/jFiaV6hm 9eegipScJEc8Z5VNkjBPT8KAU2G0/O3swZRNZ8nDoEptq4Yeo5fZcHazCW9DYJhaRk3f VrgQ== X-Gm-Message-State: AOAM533ENQ+MGtDg2N7m0W7HQB/ukdk1cRfzMvbuo5Fetb3ZJrcwYw00 35Lumj7dtW3KNzwbq2fsve6Gpz2vPgbbf4V+Tt7tpg== X-Google-Smtp-Source: ABdhPJwegWDusaTIB3bPmOpgMiGrD2mYkbQiqs76HoMQ7eqJSNZKw0GMac7Ch1kQSHF0VmZxhwOkDBBHQ5MPFnGAUOQ= X-Received: by 2002:a05:6214:15d1:: with SMTP id p17mr590706qvz.28.1614479977504; Sat, 27 Feb 2021 18:39:37 -0800 (PST) MIME-Version: 1.0 References: <202102232124.11NLOT27012354@gitrepo.freebsd.org> <01000177d0e7f033-389acb59-2004-4040-ba7c-762878ef86b4-000000@email.amazonses.com> <583f83d8-c78b-d961-d2c5-9693bd36563b@freebsd.org> <743fd126-2077-49b1-9c85-7ccc61616b98@www.fastmail.com> <460ceb98-e0c1-42b3-8e3c-2587c5ce8398@www.fastmail.com> In-Reply-To: From: Warner Losh Date: Sat, 27 Feb 2021 19:39:25 -0700 Message-ID: Subject: Re: git: 0b7472b3d8d2 - main - Mount the EFI system partition (ESP) on newly-installed systems. To: Jessica Clarke Cc: Brandon Bergren , Nathan Whitehorn , Colin Percival , src-committers , "" , dev-commits-src-main@freebsd.org X-Rspamd-Queue-Id: 4Dp6zt3Qc3z4kZq X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.34 X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 Feb 2021 02:39:38 -0000 On Sat, Feb 27, 2021, 6:25 PM Jessica Clarke wrote: > On 28 Feb 2021, at 01:22, Brandon Bergren wrote: > > > > On Sat, Feb 27, 2021, at 7:10 PM, Brandon Bergren wrote: > >> This is mistakenly detecting pseries powerpc64* as an EFI platform and > >> causing install to error out. Please add back the uname checks so this > >> code doesn't run on powerpc*. > > > > Specifically, the /boot/efi stuff in > usr.sbin/bsdinstall/scripts/bootconfig should not run on mips / 32 bit ARM > / powerpc* systems. I believe /boot/efi is always created so it can't be > used to infer existence of EFI. > > 32-bit Arm can boot via EFI. Just mips* and powerpc*. > There was some rumblings of little endian powerpc64 efi, but I don't think it's ready... > Yea, we have long since switched our preferred boot on arm to EFI... though we don't have installer images for 32bit arm, which is this runs... so it's needed for correctness, but not a practical difference... Warner >