From owner-freebsd-hackers  Tue Feb  5 12:19:28 2002
Delivered-To: freebsd-hackers@freebsd.org
Received: from elvis.mu.org (elvis.mu.org [192.203.228.196])
	by hub.freebsd.org (Postfix) with ESMTP id 86EB337B42C
	for <hackers@freebsd.org>; Tue,  5 Feb 2002 12:19:23 -0800 (PST)
Received: by elvis.mu.org (Postfix, from userid 1192)
	id 60CF410DDF8; Tue,  5 Feb 2002 12:19:23 -0800 (PST)
Date: Tue, 5 Feb 2002 12:19:23 -0800
From: Alfred Perlstein <bright@mu.org>
To: Bruce Evans <bde@zeta.org.au>
Cc: Mike Silbersack <silby@silby.com>,
	Michal Mertl <mime@traveller.cz>, hackers@freebsd.org,
	greg@bogslab.ucdavis.edu
Subject: Re: stack alignment issues
Message-ID: <20020205121923.O59017@elvis.mu.org>
References: <20020205134035.M1617-100000@patrocles.silby.com> <20020206071049.S502-100000@gamplex.bde.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5i
In-Reply-To: <20020206071049.S502-100000@gamplex.bde.org>; from bde@zeta.org.au on Wed, Feb 06, 2002 at 07:11:31AM +1100
Sender: owner-freebsd-hackers@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-hackers.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-hackers>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-hackers>
X-Loop: FreeBSD.ORG

* Bruce Evans <bde@zeta.org.au> [020205 12:09] wrote:
> On Tue, 5 Feb 2002, Mike Silbersack wrote:
> 
> > On Tue, 5 Feb 2002, Bruce Evans wrote:
> > > foo:
> > > 	pushl %ebp
> > > 	movl %esp,%ebp
> > > 	subl $8,%esp		# <- extra instruction for alignment (for foo)
> > > 	addl $-12,%esp		# <- extra instruction for alignment (for f1)
> >
> > What disgusting code.  I find it amazing that they didn't even stick in
> > some peephole optimizer to at least limit it to one operation.
> 
> It's clearly the result of work in progress :-).

I see really cruddy stuff like this every time i do a gcc -S, don't
they watch for and try to fix this sort of thing?

-- 
-Alfred Perlstein [alfred@freebsd.org]
'Instead of asking why a piece of software is using "1970s technology,"
 start asking why software is ignoring 30 years of accumulated wisdom.'
Tax deductable donations for FreeBSD: http://www.freebsdfoundation.org/

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-hackers" in the body of the message