From owner-freebsd-current@FreeBSD.ORG Tue Jun 20 17:06:31 2006 Return-Path: X-Original-To: freebsd-current@freebsd.org Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DC2A516A479; Tue, 20 Jun 2006 17:06:31 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net [66.23.211.162]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1C72F43D77; Tue, 20 Jun 2006 17:06:23 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.13.4/8.13.4) with ESMTP id k5KH64ix029410; Tue, 20 Jun 2006 13:06:09 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: Adi Pircalabu Date: Tue, 20 Jun 2006 12:50:38 -0400 User-Agent: KMail/1.9.1 References: <449015DE.6090407@fer.hr> <200606201002.07695.jhb@freebsd.org> <20060620181916.732dbc5c@apircalabu.dsd.ro> In-Reply-To: <20060620181916.732dbc5c@apircalabu.dsd.ro> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200606201250.39071.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Tue, 20 Jun 2006 13:06:10 -0400 (EDT) X-Virus-Scanned: ClamAV 0.87.1/1551/Tue Jun 20 09:37:21 2006 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,BAYES_00 autolearn=ham version=3.1.0 X-Spam-Checker-Version: SpamAssassin 3.1.0 (2005-09-13) on server.baldwin.cx Cc: Dmitry Pryanishnikov , Marcus Alves Grando , freebsd-current@freebsd.org, Hajimu UMEMOTO , Ivan Voras Subject: Re: Linux-flashplugin7 & rtld - RFC X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Jun 2006 17:06:32 -0000 On Tuesday 20 June 2006 11:19, Adi Pircalabu wrote: > On Tue, 20 Jun 2006 10:02:06 -0400 John Baldwin wrote: > > > On Friday 16 June 2006 14:25, Dmitry Pryanishnikov wrote: > > > > > > Hello! > > > > > > On Sat, 17 Jun 2006, Hajimu UMEMOTO wrote: > > > > dmitry> doesn't crash/hang anything, it just gives the > > > > dmitry> possibility to use this combination. > > > > > > > > This patch is somewhat redundant. Adding > > > > > > > > __weak_reference(dlsym, _dlsym); > > > > > > > > is enough. > > > > > > Indeed, this also works for me. It would be nice to see this > > > trivial addition committed. > > > > I agree. Do you have the __weak_reference() patch handy? > > I know that this patch, by itself, does not break anything in the base > system. It gives the possibility to use native Mozilla-based browsers > with linux-flashplugin7. It eases the task of integrating them. > But not always adding a feature leads to the desired results. Flash7 > DOES hang a lot when used with native Mozilla. Denying this isn't the > right thing to do, it will hit lots of users. > There are not as many reports as someone would expect because the patch > is not applied (yet) mainstream. Usually, if you offer a feature in a > software product, users tend to use it. > In this specific case I'd go for the solution of a separate library > used with LD_PRELOAD by Mozilla proposed by Marcus Alves Grando. > In the end, it's a matter of decision. A separate LD_PRELOAD library for a single weak symbol seems excessive. It also does not enable flash automatically, users still have to conciously choose to install the port. :) -- John Baldwin