From owner-freebsd-ports@FreeBSD.ORG  Wed Jan 26 01:55:33 2005
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: freebsd-ports@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id E4F6416A4CE; Wed, 26 Jan 2005 01:55:33 +0000 (GMT)
Received: from creme-brulee.marcuscom.com (creme-brulee.marcuscom.com
	[24.172.16.118])	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 7804B43D1F; Wed, 26 Jan 2005 01:55:33 +0000 (GMT)
	(envelope-from marcus@marcuscom.com)
Received: from shumai.marcuscom.com (shumai.marcuscom.com [192.168.1.4])
	j0Q1ttsC081585;	Tue, 25 Jan 2005 20:55:55 -0500 (EST)
	(envelope-from marcus@marcuscom.com)
From: Joe Marcus Clarke <marcus@marcuscom.com>
To: Michael Sierchio <kudzu@tenebras.com>
In-Reply-To: <41F6F431.6060005@tenebras.com>
References: <41F6F431.6060005@tenebras.com>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="=-wA1VovY74EQS2PpMympg"
Organization: MarcusCom, Inc.
Date: Tue, 25 Jan 2005 20:55:07 -0500
Message-Id: <1106704507.16118.14.camel@shumai.marcuscom.com>
Mime-Version: 1.0
X-Mailer: Evolution 2.0.3 FreeBSD GNOME Team Port 
cc: ports@freebsd.org
cc: lioux@freebsd.org
Subject: Re: FreeBSD Port: qmail-1.03_3
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 26 Jan 2005 01:55:34 -0000


--=-wA1VovY74EQS2PpMympg
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

On Tue, 2005-01-25 at 17:36 -0800, Michael Sierchio wrote:
> You have added a patch which is totally unneccesary, and I
> suggest that it be removed:
>=20
> in your patch-qmail-local....
>=20
> -     while ((k > i) && (cmds.s[k - 1] =3D=3D ' ') || (cmds.s[k - 1] =3D=
=3D '\t'))
> +     while ((k > i) && ((cmds.s[k - 1] =3D=3D ' ') || (cmds.s[k - 1] =3D=
=3D '\t')))
>=20
> This is totally bogus, the original code is correct.  Please do not
> make changes to contributed code simply because it makes it easier
> for you to understand.  There is no semantic difference between the
> two, ERGO the patch should not exist.  Please remove it.

Actually, if k is less than or equal to i and cmds.s[k-1] is a tab, then
the first bit of code evaluates to true while the second evaluates to
false.  I haven't looked at the rest of the code, but those statements
are semantically different, and I think the second is more correct.

Joe

>=20
> Shall I file a PR?
>=20
>=20
> - Michael
>=20
>=20
> _______________________________________________
> freebsd-ports@freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-ports
> To unsubscribe, send any mail to "freebsd-ports-unsubscribe@freebsd.org"
>=20
--=20
PGP Key : http://www.marcuscom.com/pgp.asc

--=-wA1VovY74EQS2PpMympg
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.0 (FreeBSD)

iD8DBQBB9vh7b2iPiv4Uz4cRAoM3AJ9+EkEVd95nHgQ5gOswfBnDrI+GnwCaA5m1
1et7i0471Yez8Hzy7kYKSjk=
=cFRw
-----END PGP SIGNATURE-----

--=-wA1VovY74EQS2PpMympg--