Date: Thu, 5 Jan 2017 12:11:07 -0500 From: Diane Bruce <db@db.net> To: marino@freebsd.org Cc: Diane Bruce <db@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r430643 - in head/comms/wsjtx: . files Message-ID: <20170105171107.GA50170@night.db.net> In-Reply-To: <8c56c1c0-5388-a74f-62df-af52146838e1@marino.st> References: <201701051620.v05GKLks070469@repo.freebsd.org> <8c56c1c0-5388-a74f-62df-af52146838e1@marino.st>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Jan 05, 2017 at 10:36:32AM -0600, John Marino wrote:
...
>
> Personally, I don't think this was necessary.
> devel/openmp has this line:
> ONLY_FOR_ARCHS= amd64 # i386
>
> wsjtx would have been "skipped" due to openmp.
> Now if openmp suddenly supports i386, wsjtx is marked broken in error.
I agree it would have been skipped due to openmp already.
>
> I would have just left it. I think Jan's point was that you shouldn't
But to me it's nicer knowing the port I am about to spend time compiling
simply won't work by glancing at it.
> put an unconditional dependency on openmp (make it optional), not that
When I can find time to figure out how to build this stupid {swear words
elided} port without openmp, or someone works out a better fix (presumably
someone else in hamradio@) it will all be looked at and fixed later.
Care to give me a hand with gnuradio? ;)
> you should mark the port BROKEN on i386. You may have misunderstood him
> to begin with.
Not really. It was just expedient for the moment.
>
> John
>
Diane
--
- db@FreeBSD.org db@db.net http://www.db.net/~db
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20170105171107.GA50170>