From owner-freebsd-stable@FreeBSD.ORG Fri Sep 20 13:25:44 2013 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 0BB275B9 for ; Fri, 20 Sep 2013 13:25:44 +0000 (UTC) (envelope-from patfbsd@davenulle.org) Received: from smtp.lamaiziere.net (net.lamaiziere.net [94.23.254.147]) by mx1.freebsd.org (Postfix) with ESMTP id C7F21279E for ; Fri, 20 Sep 2013 13:25:43 +0000 (UTC) Received: from mr129166.localdomain (mr129166.cri.univ-rennes1.fr [129.20.129.166]) by smtp.lamaiziere.net (Postfix) with ESMTPA id 23D61A110; Fri, 20 Sep 2013 15:17:06 +0200 (CEST) Received: from mr129166 (localhost [127.0.0.1]) by mr129166.localdomain (Postfix) with ESMTP id C1CE21BC; Fri, 20 Sep 2013 15:17:05 +0200 (CEST) Date: Fri, 20 Sep 2013 15:17:05 +0200 From: Patrick Lamaiziere To: freebsd-stable@freebsd.org, Konstantin Belousov Subject: Re: Possible kqueue related issue on STABLE/RC. Message-ID: <20130920151705.33aae120@mr129166> In-Reply-To: <20130912073643.GM41229@kib.kiev.ua> References: <20130911171913.GG41229@kib.kiev.ua> <20130912073643.GM41229@kib.kiev.ua> X-Mailer: Claws Mail 3.9.2 (GTK+ 2.24.19; amd64-portbld-freebsd9.1) Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Sep 2013 13:25:44 -0000 Le Thu, 12 Sep 2013 10:36:43 +0300, Konstantin Belousov a écrit : Hello, > Might be, your issue is that some filesystems do not care about proper > locking mode for the fifos. UFS carefully disables shared locking for > VFIFO, but it seems ZFS is not. I can propose the following band-aid, > which could help you. > > I have no idea is it the same issue as the kqueue panic. > > diff --git a/sys/kern/vfs_vnops.c b/sys/kern/vfs_vnops.c > index c53030a..00bd998 100644 > --- a/sys/kern/vfs_vnops.c > +++ b/sys/kern/vfs_vnops.c > @@ -267,6 +267,8 @@ vn_open_vnode(struct vnode *vp, int fmode, struct > ucred *cred, return (error); > } > } > + if (vp->v_type == VFIFO && VOP_ISLOCKED(vp) != LK_EXCLUSIVE) > + vn_lock(vp, LK_UPGRADE | LK_RETRY); > if ((error = VOP_OPEN(vp, fmode, cred, td, fp)) != 0) > return (error); > > @@ -358,7 +360,7 @@ vn_close(vp, flags, file_cred, td) > struct mount *mp; > int error, lock_flags; > > - if (!(flags & FWRITE) && vp->v_mount != NULL && > + if (vp->v_type != VFIFO && !(flags & FWRITE) && > vp->v_mount != NULL && vp->v_mount->mnt_kern_flag & > MNTK_EXTENDED_SHARED) lock_flags = LK_SHARED; > else Hmmm, So what is the fix for 9.2-STABLE ? As far I can see there is no function vn_open_vnode() here and I don't see where I should patch. I see this panic too (with STABLE of today), while using poudriere + ZFS like Jimmy. Thanks, regards