From owner-cvs-all@FreeBSD.ORG Sat Nov 5 22:23:36 2005 Return-Path: X-Original-To: cvs-all@freebsd.org Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9521216A41F; Sat, 5 Nov 2005 22:23:36 +0000 (GMT) (envelope-from marius@newtrinity.zeist.de) Received: from newtrinity.zeist.de (newtrinity.zeist.de [217.24.217.8]) by mx1.FreeBSD.org (Postfix) with ESMTP id A383143D45; Sat, 5 Nov 2005 22:23:33 +0000 (GMT) (envelope-from marius@newtrinity.zeist.de) Received: from newtrinity.zeist.de (localhost [127.0.0.1]) by newtrinity.zeist.de (8.12.11/8.12.11/ZEIST.DE) with ESMTP id jA5MNVNB024141; Sat, 5 Nov 2005 23:23:31 +0100 (CET) (envelope-from marius@newtrinity.zeist.de) Received: (from marius@localhost) by newtrinity.zeist.de (8.12.11/8.12.10/Submit) id jA5MNQhw024140; Sat, 5 Nov 2005 23:23:26 +0100 (CET) (envelope-from marius) Date: Sat, 5 Nov 2005 23:23:26 +0100 From: Marius Strobl To: Poul-Henning Kamp Message-ID: <20051105232325.A41277@newtrinity.zeist.de> References: <200511052104.jA5L4rBS020286@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5.1i In-Reply-To: <200511052104.jA5L4rBS020286@repoman.freebsd.org>; from phk@freebsd.org on Sat, Nov 05, 2005 at 09:04:53PM +0000 X-AntiVirus-modified: yes X-AntiVirus: checked by AntiVir Milter (version: 1.1.1-9; AVE: 6.32.0.58; VDF: 6.32.0.147; host: newtrinity.zeist.de) Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/puc puc.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 Nov 2005 22:23:36 -0000 On Sat, Nov 05, 2005 at 09:04:53PM +0000, Poul-Henning Kamp wrote: > > phk 2005-11-05 21:04:53 UTC > > FreeBSD src repository > > Modified files: > sys/dev/puc puc.c > Log: > Now that fast interrupts can be shared we can use them in puc. > > Revision Changes Path > 1.42 +1 -0 src/sys/dev/puc/puc.c PUC_FASTINTR used to cause problems on sparc64 where puc(4) is (ab)used to multiplex the resources of SCCs for uart(4) which then attaches to each channel of a SCC separately. IIRC what's going was that when say uart0 attaches to the first channel an interrupt fires and uart(4) doesn't manage to clear the interrupt pending bits because uart1 isn't attached to the second channel, yet, causing uart_intr() to loop endlessly. This would only happen with an INTR_FAST handler as unlike non-fast handlers the former are instantly active when set up. I'm unsure about the details, e.g. the endless loop might actually occur a bit later during probing uart1 or before it's fully attached but I think the problem is still there. Marius -- This mail was scanned by AntiVir Milter. This product is licensed for non-commercial use. See www.antivir.de for details.